Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 560883002: Adding Paste Popup behavior Unit Test cases. (Closed)

Created:
6 years, 3 months ago by AKVT
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Adding Paste Popup behavior Unit Test cases. Currently there is not enough unit test cases available to cover the functionality of Paste Popup menu behavior. This patch covers essential unit test cases for the same. These tests originally landed in r293222, but were incidentally reverted due to some pre-existing test failures in the same file. BUG= Committed: https://crrev.com/2828132575ca35b26647eeda75979999df5c7871 Cr-Commit-Position: refs/heads/master@{#294353}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -0 lines) Patch
M content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java View 4 chunks +72 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
AKVT
@jdduke PTAL. Earlier UT was indirectly reverted due to reversal of new file ContentViewCoreSelectionTest.java. Paste ...
6 years, 3 months ago (2014-09-10 15:50:28 UTC) #2
jdduke (slow)
On 2014/09/10 15:50:28, AKV wrote: > @jdduke PTAL. Earlier UT was indirectly reverted due to ...
6 years, 3 months ago (2014-09-10 20:08:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/560883002/1
6 years, 3 months ago (2014-09-11 06:52:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 685db76c35bb0ce1f297453f89f6b33157ee2741
6 years, 3 months ago (2014-09-11 08:01:23 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 08:19:23 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2828132575ca35b26647eeda75979999df5c7871
Cr-Commit-Position: refs/heads/master@{#294353}

Powered by Google App Engine
This is Rietveld 408576698