Issue 560853003: Revert of Fix test for master device.

Issue 560853003: Revert of Fix test for master device. (Closed)

Created:
6 years, 3 months ago by kpschoedel

Modified:
6 years, 3 months ago

Reviewers:
sadrul, Daniel Erat

CC:
chromium-reviews, tdresser+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Revert of Fix test for master device. (patchset #4 id:80001 of https://codereview.chromium.org/538143002/) Reason for revert: Breaks key repeat (issue 412655). Original issue's description: > Fix test for master device. > > BUG=406014 > R=sadrul@chromium.org > > Committed: https://crrev.com/817ca9b5c2145d843f6ff154926db79535974778 > Cr-Commit-Position: refs/heads/master@{#293781} TBR=sadrul@chromium.org,derat@chromium.org NOTREECHECKS=true NOTRY=true BUG=406014 Committed: https://crrev.com/36235200bd4e8237be64e8d9c6436f6474e0b3b7 Cr-Commit-Position: refs/heads/master@{#294174}

Created: 6 years, 3 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -39 lines)			Patch
M	chrome/browser/chromeos/events/event_rewriter_unittest.cc	View	2 chunks	+2 lines, -6 lines	0 comments	Download
M	ui/events/event.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/events/test/events_test_utils_x11.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	ui/events/test/events_test_utils_x11.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	ui/events/x/events_x_unittest.cc	View	3 chunks	+5 lines, -26 lines	0 comments	Download
M	ui/events/x/touch_factory_x11.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kpschoedel@chromium.org/560853003/1

6 years, 3 months ago (2014-09-10 15:19:13 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as 4889e536b343860498d5fd2b2ff1769629b92d80

6 years, 3 months ago (2014-09-10 15:31:04 UTC) #3

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/36235200bd4e8237be64e8d9c6436f6474e0b3b7 Cr-Commit-Position: refs/heads/master@{#294174}

6 years, 3 months ago (2014-09-10 15:35:33 UTC) #4

Message was sent while issue was closed.

lgtm