Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: tools/telemetry/telemetry/core/platform/tracing_controller_backend.py

Issue 560823003: Improve debugging message to show the number of running browsers upon failures (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/platform/tracing_controller_backend.py
diff --git a/tools/telemetry/telemetry/core/platform/tracing_controller_backend.py b/tools/telemetry/telemetry/core/platform/tracing_controller_backend.py
index 3625fa7439ed3940c45cac21010af69c63a9044e..87f3269cf42c97d60ac8e5686f1b2308c3a5502f 100644
--- a/tools/telemetry/telemetry/core/platform/tracing_controller_backend.py
+++ b/tools/telemetry/telemetry/core/platform/tracing_controller_backend.py
@@ -21,7 +21,8 @@ class TracingControllerBackend(object):
assert isinstance(trace_options,
tracing_options.TracingOptions)
- if len(self.running_browser_backends) != 1:
+ num_running_browser_backends = len(self.running_browser_backends)
+ if num_running_browser_backends != 1:
# Note: it is possible to implement tracing for both the case of 0 and >1.
# For >1, we just need to merge the trace files at StopTracing.
#
@@ -31,7 +32,9 @@ class TracingControllerBackend(object):
# the controller add in the trace-startup command, and then when we get
# the Stop message or the DidStopBrowser(), issue the stop tracing command
# on the right backend.
- raise NotImplementedError()
+ raise NotImplementedError(
+ 'Start tracing does not support the case of %i running browser '
+ 'instances' % num_running_browser_backends)
self._current_trace_options = trace_options
self._current_category_filter = category_filter
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698