Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Side by Side Diff: src/x87/code-stubs-x87.cc

Issue 560793002: X87: Do not cache CodeStubInterfaceDescriptor on the isolate. (Closed) Base URL: https://github.com/v8/v8.git@bleeding_edge
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/x87/lithium-x87.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_X87 7 #if V8_TARGET_ARCH_X87
8 8
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/bootstrapper.h" 10 #include "src/bootstrapper.h"
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 } 108 }
109 109
110 110
111 #define __ ACCESS_MASM(masm) 111 #define __ ACCESS_MASM(masm)
112 112
113 113
114 void HydrogenCodeStub::GenerateLightweightMiss(MacroAssembler* masm) { 114 void HydrogenCodeStub::GenerateLightweightMiss(MacroAssembler* masm) {
115 // Update the static counter each time a new code stub is generated. 115 // Update the static counter each time a new code stub is generated.
116 isolate()->counters()->code_stubs()->Increment(); 116 isolate()->counters()->code_stubs()->Increment();
117 117
118 CodeStubInterfaceDescriptor* descriptor = GetInterfaceDescriptor(); 118 CodeStubInterfaceDescriptor descriptor;
119 int param_count = descriptor->GetEnvironmentParameterCount(); 119 InitializeInterfaceDescriptor(&descriptor);
120 int param_count = descriptor.GetEnvironmentParameterCount();
120 { 121 {
121 // Call the runtime system in a fresh internal frame. 122 // Call the runtime system in a fresh internal frame.
122 FrameScope scope(masm, StackFrame::INTERNAL); 123 FrameScope scope(masm, StackFrame::INTERNAL);
123 DCHECK(param_count == 0 || 124 DCHECK(param_count == 0 ||
124 eax.is(descriptor->GetEnvironmentParameterRegister( 125 eax.is(descriptor.GetEnvironmentParameterRegister(param_count - 1)));
125 param_count - 1)));
126 // Push arguments 126 // Push arguments
127 for (int i = 0; i < param_count; ++i) { 127 for (int i = 0; i < param_count; ++i) {
128 __ push(descriptor->GetEnvironmentParameterRegister(i)); 128 __ push(descriptor.GetEnvironmentParameterRegister(i));
129 } 129 }
130 ExternalReference miss = descriptor->miss_handler(); 130 ExternalReference miss = descriptor.miss_handler();
131 __ CallExternalReference(miss, param_count); 131 __ CallExternalReference(miss, param_count);
132 } 132 }
133 133
134 __ ret(0); 134 __ ret(0);
135 } 135 }
136 136
137 137
138 void StoreBufferOverflowStub::Generate(MacroAssembler* masm) { 138 void StoreBufferOverflowStub::Generate(MacroAssembler* masm) {
139 // We don't allow a GC during a store buffer overflow so there is no need to 139 // We don't allow a GC during a store buffer overflow so there is no need to
140 // store the registers in any particular way, but we do have to store and 140 // store the registers in any particular way, but we do have to store and
(...skipping 4182 matching lines...) Expand 10 before | Expand all | Expand 10 after
4323 Operand(ebp, 7 * kPointerSize), 4323 Operand(ebp, 7 * kPointerSize),
4324 NULL); 4324 NULL);
4325 } 4325 }
4326 4326
4327 4327
4328 #undef __ 4328 #undef __
4329 4329
4330 } } // namespace v8::internal 4330 } } // namespace v8::internal
4331 4331
4332 #endif // V8_TARGET_ARCH_X87 4332 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « no previous file | src/x87/lithium-x87.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698