Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 560753002: Fix an outdated comment in external_filesystem_apitest.cc (Closed)

Created:
6 years, 3 months ago by satorux1
Modified:
6 years, 3 months ago
Reviewers:
mtomasz
CC:
chromium-reviews, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix an outdated comment in external_filesystem_apitest.cc TEST=n/a BUG=none Committed: https://crrev.com/6f3fd4fc5df531ca96e701b9a722b133b24f4430 Cr-Commit-Position: refs/heads/master@{#294145}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/chromeos/file_manager/external_filesystem_apitest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
satorux1
This is a follow-up to https://codereview.chromium.org/550863003/diff/20001/chrome/browser/chromeos/file_manager/external_filesystem_apitest.cc
6 years, 3 months ago (2014-09-10 04:44:38 UTC) #2
mtomasz
lgtm with nit https://codereview.chromium.org/560753002/diff/1/chrome/browser/chromeos/file_manager/external_filesystem_apitest.cc File chrome/browser/chromeos/file_manager/external_filesystem_apitest.cc (right): https://codereview.chromium.org/560753002/diff/1/chrome/browser/chromeos/file_manager/external_filesystem_apitest.cc#newcode47 chrome/browser/chromeos/file_manager/external_filesystem_apitest.cc:47: // app with fileManagerPrivate permission (i.e. ...
6 years, 3 months ago (2014-09-10 04:46:20 UTC) #3
satorux1
https://codereview.chromium.org/560753002/diff/1/chrome/browser/chromeos/file_manager/external_filesystem_apitest.cc File chrome/browser/chromeos/file_manager/external_filesystem_apitest.cc (right): https://codereview.chromium.org/560753002/diff/1/chrome/browser/chromeos/file_manager/external_filesystem_apitest.cc#newcode47 chrome/browser/chromeos/file_manager/external_filesystem_apitest.cc:47: // app with fileManagerPrivate permission (i.e. Files.app) On 2014/09/10 ...
6 years, 3 months ago (2014-09-10 04:48:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/560753002/20001
6 years, 3 months ago (2014-09-10 04:49:59 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/7204)
6 years, 3 months ago (2014-09-10 06:59:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/560753002/20001
6 years, 3 months ago (2014-09-10 07:01:36 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 92c0d0b38ac5fabab3fea0fe71b800d760961fd2
6 years, 3 months ago (2014-09-10 08:56:58 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 10:56:09 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6f3fd4fc5df531ca96e701b9a722b133b24f4430
Cr-Commit-Position: refs/heads/master@{#294145}

Powered by Google App Engine
This is Rietveld 408576698