Issue 56072: Make Gtk/Gdk/GLib errors/warnings really fatal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 56072: Make Gtk/Gdk/GLib errors/warnings really fatal. (Closed)

Created:
11 years, 8 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
Dean McNamee

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Make Gtk/Gdk/GLib errors/warnings really fatal. I had to disable RedirectTest because on Linux it triggered Gdk assertion. It was a bug in our logging <-> glib logging glue code that didn't make this test fail earlier. http://crbug.com/9519 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12947

Total comments: 1

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -16 lines)			Patch
M	chrome/app/chrome_dll_main.cc	View	1	2 chunks	+23 lines, -16 lines	0 comments	Download
M	chrome/chrome.gyp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/test/ui/ui_tests.scons	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Dean McNamee

LG, I guess I should have read the docs closer :( One comment: http://codereview.chromium.org/56072/diff/1/2 File ...

11 years, 8 months ago (2009-03-31 16:45:38 UTC) #2

LG, thanks