Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 560713002: Revert of Revert of allow canvas to force conservative clips (for speed) (Closed)

Created:
6 years, 3 months ago by reed2
Modified:
6 years, 3 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of Revert of allow canvas to force conservative clips (for speed) (patchset #1 id:1 of https://codereview.chromium.org/554033003/) Reason for revert: May just rebaseline, plus want to see the results of the chrome tests, so re-trying this CL. Original issue's description: > Revert of allow canvas to force conservative clips (for speed) (patchset #7 id:120001 of https://codereview.chromium.org/541593005/) > > Reason for revert: > multipicturedraw failed on nvprmsaa -- don't know why yet > > Original issue's description: > > Allow SkCanvas to be initialized to force conservative rasterclips. This has the following effects: > > > > 1. Queries to the current clip will be conservatively large. This can mean the quickReject may return false more often. > > > > 2. The conservative clips mean less work is done. > > > > 3. Enabled by default for Gpu, Record, and NoSaveLayer canvases. > > > > 4. API is private for now. > > > > Committed: https://skia.googlesource.com/skia/+/27a5e656c3d6ef22f9cb34de18e1b960da3aa241 > > TBR=robertphillips@google.com,bsalomon@google.com,mtklein@google.com,junov@google.com > NOTREECHECKS=true > NOTRY=true > > Committed: https://skia.googlesource.com/skia/+/6f09709519b79a1159f3826645f1c5fbc101ee11 TBR=robertphillips@google.com,bsalomon@google.com,mtklein@google.com,junov@google.com,reed@google.com NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/d954498c01ccf0417feacf89e45d0c62a06a813b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -187 lines) Patch
M include/core/SkCanvas.h View 3 chunks +11 lines, -6 lines 0 comments Download
M include/core/SkDevice.h View 1 chunk +2 lines, -0 lines 0 comments Download
M include/gpu/SkGpuDevice.h View 1 chunk +1 line, -0 lines 0 comments Download
M include/utils/SkNoSaveLayerCanvas.h View 2 chunks +2 lines, -16 lines 0 comments Download
M src/core/SkCanvas.cpp View 13 chunks +74 lines, -115 lines 0 comments Download
M src/core/SkDeviceLooper.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M src/core/SkPictureRecord.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M src/core/SkRasterClip.h View 4 chunks +7 lines, -3 lines 0 comments Download
M src/core/SkRasterClip.cpp View 7 chunks +142 lines, -32 lines 0 comments Download
M src/core/SkRecorder.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/AAClipTest.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M tests/PictureTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
reed2
Created Revert of Revert of allow canvas to force conservative clips (for speed)
6 years, 3 months ago (2014-09-10 01:45:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@chromium.org/560713002/1
6 years, 3 months ago (2014-09-10 01:46:11 UTC) #2
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 01:46:24 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as d954498c01ccf0417feacf89e45d0c62a06a813b

Powered by Google App Engine
This is Rietveld 408576698