Issue 56071: Enable TCMalloc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 56071: Enable TCMalloc. (Closed)

Created:
11 years, 8 months ago by Mike Belshe

Modified:
9 years, 5 months ago

Reviewers:
Dean McNamee, darin (slow to review)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Enable TCMalloc. I think this will be a good perf win. Will test on bbots. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12817

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -1 line)			Patch
	M	webkit/build/JavaScriptCore/pthread.h	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download
	M	webkit/build/webkit_common_defines.vsprops	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

OK for experimentation purposes. (As discussed, I'd be very surprised if this doesn't blow up ...

11 years, 8 months ago (2009-03-30 21:03:30 UTC) #2

Dean McNamee

11 years, 8 months ago (2009-03-31 16:11:44 UTC) #3

The results seem quite good in terms of performance, but it seems everything
took a hit in memory usage / working set size.

On 2009/03/30 21:03:30, darin wrote:
> OK for experimentation purposes.  (As discussed, I'd be very surprised if this
> doesn't blow up due to mismatched allocators.)
> 
> http://codereview.chromium.org/56071/diff/1/2
> File webkit/build/JavaScriptCore/pthread.h (right):
> 
> http://codereview.chromium.org/56071/diff/1/2#newcode85
> Line 85: TlsSetValue(key, value);
> nit: indentation

Expand Messages | Collapse Messages