Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4919)

Unified Diff: chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.cc

Issue 560703002: [SyncFS] Expand simple functions to their caller in drive_backend/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@03_context_rename
Patch Set: rebase Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.cc
diff --git a/chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.cc b/chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.cc
index 0bddbe3935f54251bf74b3948d88c61930ba5320..c34505c345ff205834a4bded3c0bb89ce59b5b2b 100644
--- a/chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.cc
+++ b/chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.cc
@@ -88,18 +88,7 @@ void SyncEngineInitializer::RunPreflight(scoped_ptr<SyncTaskToken> token) {
SyncStatusCode status = SYNC_STATUS_FAILED;
scoped_ptr<MetadataDatabase> metadata_database =
MetadataDatabase::Create(database_path_, env_override_, &status);
- // TODO(tzik): Expand this function.
- DidCreateMetadataDatabase(token.Pass(), status, metadata_database.Pass());
-}
-scoped_ptr<MetadataDatabase> SyncEngineInitializer::PassMetadataDatabase() {
- return metadata_database_.Pass();
-}
-
-void SyncEngineInitializer::DidCreateMetadataDatabase(
- scoped_ptr<SyncTaskToken> token,
- SyncStatusCode status,
- scoped_ptr<MetadataDatabase> instance) {
if (status != SYNC_STATUS_OK) {
util::Log(logging::LOG_VERBOSE, FROM_HERE,
"[Initialize] Failed to initialize MetadataDatabase.");
@@ -107,8 +96,8 @@ void SyncEngineInitializer::DidCreateMetadataDatabase(
return;
}
- DCHECK(instance);
- metadata_database_ = instance.Pass();
+ DCHECK(metadata_database);
+ metadata_database_ = metadata_database.Pass();
if (metadata_database_->HasSyncRoot()) {
util::Log(logging::LOG_VERBOSE, FROM_HERE,
"[Initialize] Found local cache of sync-root.");
@@ -119,6 +108,10 @@ void SyncEngineInitializer::DidCreateMetadataDatabase(
GetAboutResource(token.Pass());
}
+scoped_ptr<MetadataDatabase> SyncEngineInitializer::PassMetadataDatabase() {
+ return metadata_database_.Pass();
+}
+
void SyncEngineInitializer::GetAboutResource(
scoped_ptr<SyncTaskToken> token) {
set_used_network(true);
@@ -348,13 +341,6 @@ void SyncEngineInitializer::PopulateDatabase(
DCHECK(sync_root_folder_);
SyncStatusCode status = metadata_database_->PopulateInitialData(
largest_change_id_, *sync_root_folder_, app_root_folders_);
- // TODO(tzik): Expand this function.
- DidPopulateDatabase(token.Pass(), status);
-}
-
-void SyncEngineInitializer::DidPopulateDatabase(
- scoped_ptr<SyncTaskToken> token,
- SyncStatusCode status) {
if (status != SYNC_STATUS_OK) {
util::Log(logging::LOG_VERBOSE, FROM_HERE,
"[Initialize] Failed to populate initial data"
« no previous file with comments | « chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698