chrome/browser/sync_file_system/drive_backend/list_changes_task.cc - Issue 560703002: [SyncFS] Expand simple functions to their caller in drive_backend/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync_file_system/drive_backend/list_changes_task.cc

Issue 560703002: [SyncFS] Expand simple functions to their caller in drive_backend/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@03_context_rename

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync_file_system/drive_backend/list_changes_task.h ('k') | chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.h » ('j') | chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync_file_system/drive_backend/list_changes_task.cc

diff --git a/chrome/browser/sync_file_system/drive_backend/list_changes_task.cc b/chrome/browser/sync_file_system/drive_backend/list_changes_task.cc

index c7828b0df4679696a7676d96bae11cf4cef2d17c..3d357c1ef170c617882acb827814df117fba649b 100644

--- a/chrome/browser/sync_file_system/drive_backend/list_changes_task.cc

+++ b/chrome/browser/sync_file_system/drive_backend/list_changes_task.cc

@@ -124,12 +124,6 @@ void ListChangesTask::CheckInChangeList(int64 largest_change_id,

metadata_database()->UpdateByChangeList(

largest_change_id, change_list_.Pass());

peria 2014/09/10 01:59:01 nit: There is an extra line.

tzik 2014/09/10 05:00:22 Done.

- // TODO(tzik): Expand this function.

- DidCheckInChangeList(token.Pass(), status);

-void ListChangesTask::DidCheckInChangeList(scoped_ptr<SyncTaskToken> token,

- SyncStatusCode status) {

if (status != SYNC_STATUS_OK) {

SyncTaskManager::NotifyTaskDone(token.Pass(), status);

return;