Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 560683003: Adds swift file support to xcode generation. (Closed)

Created:
6 years, 3 months ago by jconverse
Modified:
6 years, 3 months ago
Reviewers:
dmac, TVL, justincohen, blundell
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Adds swift file support to xcode generation. BUG= Patch from Josh Converse <jconverse@google.com>! R=justincohen@chromium.org, thomasvl@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1980

Patch Set 1 #

Patch Set 2 : Adds unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -6 lines) Patch
M pylib/gyp/generator/xcode.py View 1 chunk +1 line, -1 line 0 comments Download
M pylib/gyp/xcodeproj_file.py View 1 chunk +1 line, -0 lines 0 comments Download
A test/mac/gyptest-swift-library.py View 1 1 chunk +62 lines, -0 lines 0 comments Download
A test/mac/swift-library/Info.plist View 1 1 chunk +28 lines, -0 lines 0 comments Download
A test/mac/swift-library/file.swift View 1 1 chunk +9 lines, -0 lines 0 comments Download
A + test/mac/swift-library/test.gyp View 1 1 chunk +8 lines, -5 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
jconverse
This CL adds support for .swift files as valid source files in the XCode generator.
6 years, 3 months ago (2014-09-17 18:47:02 UTC) #4
jconverse
6 years, 3 months ago (2014-09-17 23:27:39 UTC) #6
TVL
Justin - not that I expect chrome on iOS to use swift any time soon, ...
6 years, 3 months ago (2014-09-18 14:09:50 UTC) #7
justincohen
I wouldn't be surprised if one of our dependencies will start using swift. What did ...
6 years, 3 months ago (2014-09-18 14:13:25 UTC) #9
jconverse
On 2014/09/18 14:13:25, justincohen wrote: > I wouldn't be surprised if one of our dependencies ...
6 years, 3 months ago (2014-09-18 20:08:19 UTC) #10
TVL
lgtm LG, I'll try to land this later (since commit queue doesn't work on gyp)
6 years, 3 months ago (2014-09-22 20:51:35 UTC) #11
justincohen
LG, but please add tests
6 years, 3 months ago (2014-09-22 21:26:41 UTC) #12
jconverse
On 2014/09/22 21:26:41, justincohen wrote: > LG, but please add tests Done!
6 years, 3 months ago (2014-09-23 00:25:59 UTC) #13
justincohen
lgtm thanks!
6 years, 3 months ago (2014-09-23 13:29:54 UTC) #14
justincohen
Committed patchset #2 (id:20001) manually as 1980 (presubmit successful).
6 years, 3 months ago (2014-09-23 16:49:15 UTC) #15
blundell
Do any changes need to be made to the ninja generator to have it support ...
6 years, 3 months ago (2014-09-24 11:53:47 UTC) #17
justincohen
6 years, 3 months ago (2014-09-24 12:01:26 UTC) #18
Message was sent while issue was closed.
Yes

Powered by Google App Engine
This is Rietveld 408576698