Source/core/editing/TextIterator.cpp - Issue 560653003: Fix bug in BackwardsCharacterIterator::endPosition introduced in latest change.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/TextIterator.cpp

Issue 560653003: Fix bug in BackwardsCharacterIterator::endPosition introduced in latest change. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/TextIterator.cpp

diff --git a/Source/core/editing/TextIterator.cpp b/Source/core/editing/TextIterator.cpp

index c11f0d8bc5e3f672b39f41dcf806232618fb6148..ebc655382b6b5972f74fcbe8b8b697ac2fb60e85 100644

--- a/Source/core/editing/TextIterator.cpp

+++ b/Source/core/editing/TextIterator.cpp

@@ -1733,7 +1733,7 @@ PassRefPtrWillBeRawPtr<Range> BackwardsCharacterIterator::range() const

Position BackwardsCharacterIterator::endPosition() const

{

Node* n = m_textIterator.startContainer();

- if (m_textIterator.atEnd()) {

+ if (!m_textIterator.atEnd()) {

if (m_textIterator.length() > 1)

return createLegacyEditingPosition(n, m_textIterator.endOffset() - m_runOffset);

ASSERT(!m_runOffset);

« no previous file with comments | « no previous file | no next file » | no next file with comments »