Remove GamePad runtime flag(status=stable)

Remove GamePad runtime flag(status=stable)

BUG=402536

[zhaoze.zhou, 2014-09-09 23:30:17]

zhaoze.zhou@partner.samsung.com changed reviewers:
+ rob.buis@samsung.com

[rwlbuis, 2014-09-09 23:50:18]

Looks ok, one concern below.

https://codereview.chromium.org/560653002/diff/1/Source/web/FrameLoaderClient...
File Source/web/FrameLoaderClientImpl.cpp (left):

https://codereview.chromium.org/560653002/diff/1/Source/web/FrameLoaderClient...
Source/web/FrameLoaderClientImpl.cpp:122: NavigatorGamepad::from(*document);
NavigatorGamepad::from(*document); should be kept, right?

https://codereview.chromium.org/560653002/diff/1/Source/web/FrameLoaderClient...
File Source/web/FrameLoaderClientImpl.cpp (right):

https://codereview.chromium.org/560653002/diff/1/Source/web/FrameLoaderClient...
Source/web/FrameLoaderClientImpl.cpp:120:
DeviceLightController::from(*document);
NavigatorGamepad::from(*document) call should be kept right?

[zhaoze.zhou, 2014-09-10 12:54:30]

https://codereview.chromium.org/560653002/diff/1/Source/web/FrameLoaderClient...
File Source/web/FrameLoaderClientImpl.cpp (right):

https://codereview.chromium.org/560653002/diff/1/Source/web/FrameLoaderClient...
Source/web/FrameLoaderClientImpl.cpp:120:
DeviceLightController::from(*document);
On 2014/09/09 23:50:18, rwlbuis wrote:
> NavigatorGamepad::from(*document) call should be kept right?

Done.

[rwlbuis, 2014-09-10 14:29:53]

Looks ok. Please update the changelog though, instead of repeating the CL title
2 times better add some explanation:)
Also would be good if Balazs could have look.

[zhaoze.zhou, 2014-09-10 14:37:57]

zhaoze.zhou@partner.samsung.com changed reviewers:
+ b.kelemen@samsung.com

[zhaoze.zhou, 2014-09-10 22:22:19]

zhaoze.zhou@partner.samsung.com changed reviewers:
+ bajones@chromium.org

[kbalazs, 2014-09-10 22:24:25]

Looks good module please clean up the description. Brandon? Do you agree this is
stable enough to remove the flag?

[bajones, 2014-09-10 22:26:53]

On 2014/09/10 at 22:24:25, b.kelemen wrote:
> Looks good module please clean up the description. Brandon? Do you agree this
is stable enough to remove the flag?

Agreed. To be honest I didn't realize it still had a RuntimeEnabledFeature flag!

[zhaoze.zhou, 2014-09-10 22:43:53]

zhaoze.zhou@partner.samsung.com changed reviewers:
+ abarth@chromium.org, eseidel@chromium.org

[zhaoze.zhou, 2014-09-10 22:43:54]

eseidel@chromium.org:

abarth@chromium.org:

Please take a look, thanks.

[kbalazs, 2014-09-10 23:09:55]

Source/modules/gamepad lgtm

[eseidel, 2014-09-10 23:38:29]

The CQ bit was checked by eseidel@chromium.org

[eseidel, 2014-09-10 23:38:29]

lgtm

[commit-bot: I haz the power, 2014-09-10 23:39:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/560653002/20001

[commit-bot: I haz the power, 2014-09-10 23:56:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-10 23:56:59]

Try jobs failed on following builders:
  android_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_db...)
  android_blink_compile_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_re...)
  android_chromium_gn_compile_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_comp...)

[zhaoze.zhou, 2014-09-12 17:34:52]

On 2014/09/10 23:56:59, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   android_blink_compile_dbg on tryserver.blink
>
(http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_db...)
>   android_blink_compile_rel on tryserver.blink
>
(http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_re...)
>   android_chromium_gn_compile_rel on tryserver.blink
>
(http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_comp...)

Close this cl, because for android, it must use the API

[kbalazs, 2014-09-12 17:40:07]

On 2014/09/12 17:34:52, zhaoze.zhou wrote:
> On 2014/09/10 23:56:59, I haz the power (commit-bot) wrote:
> > Try jobs failed on following builders:
> >   android_blink_compile_dbg on tryserver.blink
> >
>
(http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_db...)
> >   android_blink_compile_rel on tryserver.blink
> >
>
(http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_re...)
> >   android_chromium_gn_compile_rel on tryserver.blink
> >
>
(http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_comp...)
> 
> Close this cl, because for android, it must use the API

A bit more context. As the implementation requires Jelly Bean or beyond, we
cannot enable it unconditionally. And having a flag for it is still the most
straightforward way to communicate it to Blink which needs to take care of and
prevent exposing the js API. So we actually need the flag. Maybe it would make
sense to just add a comment in RuntimeFeatures.in about why this stable flag
need to be kept.