Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 56063002: [Android]: Only kill 'adb' during device status check, not all commands with adb in command line. (Closed)

Created:
7 years, 1 month ago by rmcilroy
Modified:
7 years, 1 month ago
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach, Dominik Grewe
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Android]: Only kill 'adb' during device status check, not all commands with adb in command line. This was causing the perf tests to fail since the bb_device_steps_internal.py had '--adb-root' as an argument and so was being accidentially killed during the device status check. BUG=312285 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232610

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/android/buildbot/bb_device_status_check.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
rmcilroy
navabi: please take a look - this bug is currently preventing any of the downstream ...
7 years, 1 month ago (2013-11-01 15:52:56 UTC) #1
Isaac (away)
I added a comment on the original CL. https://codereview.chromium.org/39833003/ This whole section seems problematic.
7 years, 1 month ago (2013-11-01 19:13:38 UTC) #2
navabi
On 2013/11/01 19:13:38, Isaac wrote: > I added a comment on the original CL. https://codereview.chromium.org/39833003/ ...
7 years, 1 month ago (2013-11-01 20:25:40 UTC) #3
rmcilroy
On 2013/11/01 20:25:40, navabi wrote: > On 2013/11/01 19:13:38, Isaac wrote: > > I added ...
7 years, 1 month ago (2013-11-01 21:58:12 UTC) #4
Isaac (away)
This doesn't make the code worse, so LGTM. It's possible it will reduce the utility ...
7 years, 1 month ago (2013-11-01 22:28:41 UTC) #5
navabi
On 2013/11/01 22:28:41, Isaac wrote: > This doesn't make the code worse, so LGTM. It's ...
7 years, 1 month ago (2013-11-01 22:37:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/56063002/1
7 years, 1 month ago (2013-11-01 22:57:48 UTC) #7
commit-bot: I haz the power
List of reviewers changed. bulach@chromium.org,tonyg@chromium.org did a drive-by without LGTM'ing!
7 years, 1 month ago (2013-11-02 02:26:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/56063002/1
7 years, 1 month ago (2013-11-02 06:10:29 UTC) #9
commit-bot: I haz the power
7 years, 1 month ago (2013-11-02 13:49:00 UTC) #10
Message was sent while issue was closed.
Change committed as 232610

Powered by Google App Engine
This is Rietveld 408576698