Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Unified Diff: chrome/browser/chromeos/input_method/input_method_util_unittest.cc

Issue 560623003: Update the input method ID migration map for new VPD design. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nit. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/input_method/input_method_util.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/input_method/input_method_util_unittest.cc
diff --git a/chrome/browser/chromeos/input_method/input_method_util_unittest.cc b/chrome/browser/chromeos/input_method/input_method_util_unittest.cc
index da79a35533b39028a2f103422cf38a0275c647ce..ac3201ff936d0599497a6ab664a6e775a2992563 100644
--- a/chrome/browser/chromeos/input_method/input_method_util_unittest.cc
+++ b/chrome/browser/chromeos/input_method/input_method_util_unittest.cc
@@ -451,5 +451,34 @@ TEST_F(InputMethodUtilTest, TestIBusInputMethodText) {
}
}
+// Test the input method ID migration.
+TEST_F(InputMethodUtilTest, TestInputMethodIDMigration) {
+ const char* const migration_cases[][2] = {
+ {"ime:zh:pinyin", "zh-t-i0-pinyin"},
+ {"ime:zh-t:zhuyin", "zh-hant-t-i0-und"},
+ {"ime:zh-t:quick", "zh-hant-t-i0-cangjie-1987-x-m0-simplified"},
+ {"ime:jp:mozc_us", "nacl_mozc_us"},
+ {"ime:ko:hangul", "hangul_2set"},
+ {"m17n:deva_phone", "vkd_deva_phone"},
+ {"m17n:ar", "vkd_ar"},
+ {"t13n:hi", "hi-t-i0-und"},
+ {"unknown", "unknown"},
+ };
+ std::vector<std::string> input_method_ids;
+ for (size_t i = 0; i < arraysize(migration_cases); ++i)
+ input_method_ids.push_back(migration_cases[i][0]);
+ // Duplicated hangul_2set.
+ input_method_ids.push_back("ime:ko:hangul_2set");
+
+ util_.MigrateInputMethods(&input_method_ids);
+
+ EXPECT_EQ(arraysize(migration_cases), input_method_ids.size());
+ for (size_t i = 0; i < arraysize(migration_cases); ++i) {
+ EXPECT_EQ(
+ extension_ime_util::GetInputMethodIDByEngineID(migration_cases[i][1]),
+ input_method_ids[i]);
+ }
+}
+
} // namespace input_method
} // namespace chromeos
« no previous file with comments | « chrome/browser/chromeos/input_method/input_method_util.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698