Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 560623003: Update the input method ID migration map for new VPD design. (Closed)

Created:
6 years, 3 months ago by Shu Chen
Modified:
6 years, 3 months ago
Reviewers:
Seigo Nonaka
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org, jsalz, xiangye_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update the input method ID migration map for new VPD design. BUG=393889 TEST=Verified by unit_tests. Committed: https://crrev.com/c02f22eaa156b2b167ebce5b6f66d38c5b913445 Cr-Commit-Position: refs/heads/master@{#294133}

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -8 lines) Patch
M chrome/browser/chromeos/input_method/input_method_util.cc View 2 chunks +39 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util_unittest.cc View 1 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Shu Chen
Nona, can you please review this cl? Thanks
6 years, 3 months ago (2014-09-10 06:14:28 UTC) #2
Seigo Nonaka
lgtm with tiny nits. https://codereview.chromium.org/560623003/diff/1/chrome/browser/chromeos/input_method/input_method_util_unittest.cc File chrome/browser/chromeos/input_method/input_method_util_unittest.cc (right): https://codereview.chromium.org/560623003/diff/1/chrome/browser/chromeos/input_method/input_method_util_unittest.cc#newcode476 chrome/browser/chromeos/input_method/input_method_util_unittest.cc:476: for (size_t i = 0; ...
6 years, 3 months ago (2014-09-10 06:17:33 UTC) #3
Shu Chen
Thanks for the review! https://codereview.chromium.org/560623003/diff/1/chrome/browser/chromeos/input_method/input_method_util_unittest.cc File chrome/browser/chromeos/input_method/input_method_util_unittest.cc (right): https://codereview.chromium.org/560623003/diff/1/chrome/browser/chromeos/input_method/input_method_util_unittest.cc#newcode476 chrome/browser/chromeos/input_method/input_method_util_unittest.cc:476: for (size_t i = 0; ...
6 years, 3 months ago (2014-09-10 06:21:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shuchen@chromium.org/560623003/20001
6 years, 3 months ago (2014-09-10 06:23:41 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as a66eac63ec79d158c5b75a19c13af4a69aaf26c5
6 years, 3 months ago (2014-09-10 07:27:48 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 07:30:14 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/c02f22eaa156b2b167ebce5b6f66d38c5b913445
Cr-Commit-Position: refs/heads/master@{#294133}

Powered by Google App Engine
This is Rietveld 408576698