Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1482)

Unified Diff: Source/web/WebViewImpl.h

Issue 560623002: Adjust maximum scroll bounds on FrameView to account for top controls. (Blink-side) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/frame/FrameView.cpp ('k') | Source/web/WebViewImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebViewImpl.h
diff --git a/Source/web/WebViewImpl.h b/Source/web/WebViewImpl.h
index 0b8cd9365639bb0e62fe3e297753aaad307843bb..f3fd2c3d14cabdd3ea0324b6be4bdbc9e38dd047 100644
--- a/Source/web/WebViewImpl.h
+++ b/Source/web/WebViewImpl.h
@@ -498,7 +498,10 @@ public:
bool matchesHeuristicsForGpuRasterizationForTesting() const { return m_matchesHeuristicsForGpuRasterization; }
+ virtual void setTopControlsLayoutHeight(float) OVERRIDE;
+
private:
+ void didUpdateTopControls();
void setTopControlsContentOffset(float);
// TODO(bokan): Remains for legacy pinch. Remove once it's gone. Made private to
@@ -734,7 +737,13 @@ private:
float m_zoomFactorOverride;
bool m_userGestureObserved;
+
+ // The top controls offset since the last compositor commit.
float m_topControlsContentOffset;
+
+ // The top controls offset at the time of the last Resize event. This is the
+ // amount that the viewport was shrunk by to accomodate the top controls.
+ float m_topControlsLayoutHeight;
};
// We have no ways to check if the specified WebView is an instance of
« no previous file with comments | « Source/core/frame/FrameView.cpp ('k') | Source/web/WebViewImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698