Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1403)

Issue 560613002: Shrink QualifiedNameImpl by 8 bytes on 64-bit platforms (Closed)

Created:
6 years, 3 months ago by rwlbuis
Modified:
6 years, 3 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Shrink QualifiedNameImpl by 8 bytes on 64-bit platforms Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181773

Patch Set 1 #

Patch Set 2 : Add COMPILE_ASSERT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M Source/core/dom/QualifiedName.h View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/core/dom/QualifiedName.cpp View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
rwlbuis
PTAL
6 years, 3 months ago (2014-09-09 23:52:04 UTC) #2
rwlbuis
Adding Eric for this easy review :)
6 years, 3 months ago (2014-09-10 20:14:14 UTC) #4
eseidel
Please add a COMPILE_ASSERT for the size then.
6 years, 3 months ago (2014-09-10 20:43:07 UTC) #5
rwlbuis
On 2014/09/10 20:43:07, eseidel wrote: > Please add a COMPILE_ASSERT for the size then. Done!
6 years, 3 months ago (2014-09-10 21:00:56 UTC) #7
eseidel
lgtm
6 years, 3 months ago (2014-09-10 21:54:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/560613002/40001
6 years, 3 months ago (2014-09-10 21:54:54 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 23:23:54 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as 181773

Powered by Google App Engine
This is Rietveld 408576698