components/policy/core/common/cloud/policy_builder.cc - Issue 560583002: Generalize crypto::SignatureCreator to allow choice of hash function, so as to support SHA256 (not …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/cloud/policy_builder.cc

Issue 560583002: Generalize crypto::SignatureCreator to allow choice of hash function, so as to support SHA256 (not … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase, fix some lint issues, and a shameful missing ")" Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/policy/core/common/cloud/policy_builder.cc

diff --git a/components/policy/core/common/cloud/policy_builder.cc b/components/policy/core/common/cloud/policy_builder.cc

index d6ea5ed76d76942b763c9fce957c20175698a736..e0d3a1a13fda43aa07e217c9617f963a9681b8f3 100644

--- a/components/policy/core/common/cloud/policy_builder.cc

+++ b/components/policy/core/common/cloud/policy_builder.cc

@@ -295,7 +295,8 @@ void PolicyBuilder::SignData(const std::string& data,

crypto::RSAPrivateKey* key,

std::string* signature) {

scoped_ptr<crypto::SignatureCreator> signature_creator(

- crypto::SignatureCreator::Create(key));

+ crypto::SignatureCreator::Create(key,

+ crypto::SignatureCreator::SHA1));

signature_creator->Update(reinterpret_cast<const uint8*>(data.c_str()),

data.size());

std::vector<uint8> signature_bytes;

« no previous file with comments | « components/ownership/owner_settings_service.cc ('k') | crypto/signature_creator.h » ('j') | no next file with comments »