chrome/browser/extensions/extension_creator.cc - Issue 560583002: Generalize crypto::SignatureCreator to allow choice of hash function, so as to support SHA256 (not …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_creator.cc

Issue 560583002: Generalize crypto::SignatureCreator to allow choice of hash function, so as to support SHA256 (not … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase, fix some lint issues, and a shameful missing ")" Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/extension_creator.cc

diff --git a/chrome/browser/extensions/extension_creator.cc b/chrome/browser/extensions/extension_creator.cc

index e79b454812e17a300d1a8bff7127ea847136c9fd..fcf31b389f32f7e96690aa85500e04f7f6c85ca3 100644

--- a/chrome/browser/extensions/extension_creator.cc

+++ b/chrome/browser/extensions/extension_creator.cc

@@ -211,7 +211,8 @@ bool ExtensionCreator::SignZip(const base::FilePath& zip_path,

crypto::RSAPrivateKey* private_key,

std::vector<uint8>* signature) {

scoped_ptr<crypto::SignatureCreator> signature_creator(

- crypto::SignatureCreator::Create(private_key));

+ crypto::SignatureCreator::Create(private_key,

+ crypto::SignatureCreator::SHA1));

base::ScopedFILE zip_handle(base::OpenFile(zip_path, "rb"));

size_t buffer_size = 1 << 16;

scoped_ptr<uint8[]> buffer(new uint8[buffer_size]);

« no previous file with comments | « chrome/browser/devtools/device/usb/android_rsa.cc ('k') | components/ownership/owner_settings_service.cc » ('j') | no next file with comments »