chrome/browser/chromeos/ownership/owner_settings_service.cc - Issue 560583002: Generalize crypto::SignatureCreator to allow choice of hash function, so as to support SHA256 (not …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/ownership/owner_settings_service.cc

Issue 560583002: Generalize crypto::SignatureCreator to allow choice of hash function, so as to support SHA256 (not … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove unnecessary backwards compatibility and update call sites Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chromeos/ownership/owner_settings_service.cc

diff --git a/chrome/browser/chromeos/ownership/owner_settings_service.cc b/chrome/browser/chromeos/ownership/owner_settings_service.cc

index 9246a0599dac2f88155c2c4a805f400e2f25dc7a..1334a495a02def71807eacf711dcf4b102af09f0 100644

--- a/chrome/browser/chromeos/ownership/owner_settings_service.cc

+++ b/chrome/browser/chromeos/ownership/owner_settings_service.cc

@@ -94,7 +94,8 @@ std::string AssembleAndSignPolicy(scoped_ptr<em::PolicyData> policy,

// Generate the signature.

scoped_ptr<crypto::SignatureCreator> signature_creator(

- crypto::SignatureCreator::Create(private_key));

+ crypto::SignatureCreator::Create(private_key,

+ crypto::SignatureCreator::SHA1);

dougsteed 2014/09/18 18:04:40 Noticed the missing ")" myself. Will be fixed in n

signature_creator->Update(

reinterpret_cast<const uint8*>(policy_response.policy_data().c_str()),

policy_response.policy_data().size());

« no previous file with comments | « no previous file | chrome/browser/devtools/device/usb/android_rsa.cc » ('j') | crypto/signature_creator_openssl.cc » ('J')