net/spdy/spdy_session.cc - Issue 560573002: Introduce new SPDY Version UMA histogram.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_session.cc

Issue 560573002: Introduce new SPDY Version UMA histogram. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make NextProto values permanent. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/spdy/spdy_session.cc

diff --git a/net/spdy/spdy_session.cc b/net/spdy/spdy_session.cc

index fc22ae4ea04ddfed5bd25decd2e7f59c5e557cc3..81ea62c8155781918a6f19bae922516640fef10c 100644

--- a/net/spdy/spdy_session.cc

+++ b/net/spdy/spdy_session.cc

@@ -719,7 +719,8 @@ void SpdySession::InitializeWithSocket(

enable_compression_));

buffered_spdy_framer_->set_visitor(this);

buffered_spdy_framer_->set_debug_visitor(this);

- UMA_HISTOGRAM_ENUMERATION("Net.SpdyVersion", protocol_, kProtoMaximumVersion);

+ UMA_HISTOGRAM_ENUMERATION(

+ "Net.SpdyVersion2", protocol_, kProtoSPDYMaximumVersion + 1);

Alexei Svitkine (slow) 2014/09/12 20:23:06 Now that you're expanded the range of the values,

Bence 2014/09/12 20:31:13 Done.

#if defined(SPDY_PROXY_AUTH_ORIGIN)

UMA_HISTOGRAM_BOOLEAN("Net.SpdySessions_DataReductionProxy",

host_port_pair().Equals(HostPortPair::FromURL(