Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Unified Diff: net/socket/next_proto.h

Issue 560573002: Introduce new SPDY Version UMA histogram. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Subtract kProtoSPDYMinimumVersion instead of using sparse histogram. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/spdy/spdy_session.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/next_proto.h
diff --git a/net/socket/next_proto.h b/net/socket/next_proto.h
index 19ff55e0bc020fe3b9e3c213c1c6f5af9f985167..08e6801532791ceea88365a9a6121b911db19433 100644
--- a/net/socket/next_proto.h
+++ b/net/socket/next_proto.h
@@ -14,20 +14,21 @@ namespace net {
// Next Protocol Negotiation (NPN), if successful, results in agreement on an
// application-level string that specifies the application level protocol to
// use over the TLS connection. NextProto enumerates the application level
-// protocols that we recognise.
+// protocols that we recognise. Do not change or reuse values, because they
+// are used to collect statistics on UMA.
enum NextProto {
kProtoUnknown = 0,
- kProtoHTTP11,
+ kProtoHTTP11 = 1,
kProtoMinimumVersion = kProtoHTTP11,
- kProtoDeprecatedSPDY2,
+ kProtoDeprecatedSPDY2 = 100,
kProtoSPDYMinimumVersion = kProtoDeprecatedSPDY2,
- kProtoSPDY3,
- kProtoSPDY31,
- kProtoSPDY4, // SPDY4 is HTTP/2.
+ kProtoSPDY3 = 101,
+ kProtoSPDY31 = 102,
+ kProtoSPDY4 = 103, // SPDY4 is HTTP/2.
kProtoSPDYMaximumVersion = kProtoSPDY4,
- kProtoQUIC1SPDY3,
+ kProtoQUIC1SPDY3 = 200,
kProtoMaximumVersion = kProtoQUIC1SPDY3,
};
« no previous file with comments | « no previous file | net/spdy/spdy_session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698