Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 560563003: [GCM] Adding GCMAccountMapper tests (Closed)

Created:
6 years, 3 months ago by fgorski
Modified:
6 years, 3 months ago
Reviewers:
jianli
CC:
chromium-reviews, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[GCM] Adding GCMAccountMapper tests Patch updated after a revert. Original patch: https://codereview.chromium.org/544363002/ 1) When the status is ADDING (adding message is sent), the token is refreshed. 2) When the status is REMOVING (removing message is sent), the token is added again. 3) updating multiple account mappings BUG=374969 R=jianli@chromium.org Committed: https://crrev.com/93f486469d03bf0333e92b2c69e471af4e17b787 Cr-Commit-Position: refs/heads/master@{#294259}

Patch Set 1 #

Patch Set 2 : Fixes to the multi account tests #

Total comments: 2

Patch Set 3 : Addresssing CR feedback - extracting verification #

Unified diffs Side-by-side diffs Delta from patch set Stats (+289 lines, -32 lines) Patch
M components/gcm_driver/gcm_account_mapper_unittest.cc View 1 2 22 chunks +289 lines, -32 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
fgorski
Jian, PTAL, patchset 1 is the original, patchset 2 is the fix.
6 years, 3 months ago (2014-09-09 21:29:04 UTC) #1
jianli
https://codereview.chromium.org/560563003/diff/20001/components/gcm_driver/gcm_account_mapper_unittest.cc File components/gcm_driver/gcm_account_mapper_unittest.cc (right): https://codereview.chromium.org/560563003/diff/20001/components/gcm_driver/gcm_account_mapper_unittest.cc#newcode758 components/gcm_driver/gcm_account_mapper_unittest.cc:758: actual_iter = mappings.begin(); Could you please introduce a helper ...
6 years, 3 months ago (2014-09-10 21:07:55 UTC) #2
fgorski
PTAL https://codereview.chromium.org/560563003/diff/20001/components/gcm_driver/gcm_account_mapper_unittest.cc File components/gcm_driver/gcm_account_mapper_unittest.cc (right): https://codereview.chromium.org/560563003/diff/20001/components/gcm_driver/gcm_account_mapper_unittest.cc#newcode758 components/gcm_driver/gcm_account_mapper_unittest.cc:758: actual_iter = mappings.begin(); On 2014/09/10 21:07:55, jianli wrote: ...
6 years, 3 months ago (2014-09-10 21:30:19 UTC) #3
jianli
lgtm
6 years, 3 months ago (2014-09-10 21:34:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fgorski@chromium.org/560563003/40001
6 years, 3 months ago (2014-09-10 21:37:29 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 4a0128671a416d2a8a5e419607abce272dae6e23
6 years, 3 months ago (2014-09-10 23:38:51 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 23:41:56 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/93f486469d03bf0333e92b2c69e471af4e17b787
Cr-Commit-Position: refs/heads/master@{#294259}

Powered by Google App Engine
This is Rietveld 408576698