Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1924)

Issue 560563002: Add default impl for DemuxerStream::EnableBitstreamConverter(); (Closed)

Created:
6 years, 3 months ago by xhwang
Modified:
6 years, 3 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, tim (not reviewing)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add default impl for DemuxerStream::EnableBitstreamConverter(). Most DemuxerStream implementation doesn't need this method. Provide an empty default implementation in the base class so that subclass doesn't need to override it. TBR=gunsch@chromium.org Committed: https://crrev.com/a1a1d99b8260260c13afcd4ba9d209f25f506bb9 Cr-Commit-Position: refs/heads/master@{#294102}

Patch Set 1 #

Total comments: 2

Patch Set 2 : comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -13 lines) Patch
M chromecast/media/cma/filters/demuxer_stream_adapter_unittest.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M media/base/demuxer_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M media/base/demuxer_stream.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M media/filters/chunk_demuxer.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/filters/chunk_demuxer.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M media/filters/fake_demuxer_stream.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/filters/fake_demuxer_stream.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
xhwang
acolwell@: PTAL tim@: FYI
6 years, 3 months ago (2014-09-09 21:07:34 UTC) #2
acolwell GONE FROM CHROMIUM
https://codereview.chromium.org/560563002/diff/1/media/filters/decrypting_demuxer_stream.cc File media/filters/decrypting_demuxer_stream.cc (left): https://codereview.chromium.org/560563002/diff/1/media/filters/decrypting_demuxer_stream.cc#oldcode130 media/filters/decrypting_demuxer_stream.cc:130: demuxer_stream_->EnableBitstreamConverter(); Why is this getting removed? Don't you still ...
6 years, 3 months ago (2014-09-09 22:28:18 UTC) #3
xhwang
comments addressed
6 years, 3 months ago (2014-09-09 22:45:28 UTC) #4
xhwang
https://codereview.chromium.org/560563002/diff/1/media/filters/decrypting_demuxer_stream.cc File media/filters/decrypting_demuxer_stream.cc (left): https://codereview.chromium.org/560563002/diff/1/media/filters/decrypting_demuxer_stream.cc#oldcode130 media/filters/decrypting_demuxer_stream.cc:130: demuxer_stream_->EnableBitstreamConverter(); On 2014/09/09 22:28:17, acolwell wrote: > Why is ...
6 years, 3 months ago (2014-09-09 22:50:38 UTC) #5
acolwell GONE FROM CHROMIUM
lgtm
6 years, 3 months ago (2014-09-09 22:52:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/560563002/20001
6 years, 3 months ago (2014-09-09 23:52:13 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/11956)
6 years, 3 months ago (2014-09-10 01:49:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/560563002/20001
6 years, 3 months ago (2014-09-10 03:26:05 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001) as e47efc961b8da4aa7420b91ff3d899e37a32ce2d
6 years, 3 months ago (2014-09-10 04:28:56 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 04:33:30 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a1a1d99b8260260c13afcd4ba9d209f25f506bb9
Cr-Commit-Position: refs/heads/master@{#294102}

Powered by Google App Engine
This is Rietveld 408576698