Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 56053005: linux_aura: Improve window drag performance. (Closed)

Created:
7 years, 1 month ago by Elliot Glaysher
Modified:
7 years, 1 month ago
CC:
chromium-reviews, piman+watch_chromium.org, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, yukishiino+watch_chromium.org, tfarina, jam, penghuang+watch_chromium.org, dcheng, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, kalyank, ben+aura_chromium.org, danakj+watch_chromium.org, James Su, ben+views_chromium.org, miu+watch_chromium.org
Visibility:
Public.

Description

linux_aura: Improve window drag performance. By delaying actually moving the window, we stop flooding the message loop. This helps, but doesn't perfectly solve, the performance problems with message dragging. This patch adds a lot of TRACE_EVENT calls which were used to narrow down exactly what was going on. BUG=313903 R=ben@chromium.org, piman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233035

Patch Set 1 #

Patch Set 2 : Rebase to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -3 lines) Patch
M chrome/browser/ui/aura/tabs/dock_info_auralinux.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller.cc View 10 chunks +27 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/toolbar_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/aura/root_window.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M ui/base/x/x11_util.cc View 3 chunks +5 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_x11.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_desktop_window_move_client.h View 4 chunks +10 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_desktop_window_move_client.cc View 1 3 chunks +37 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Elliot Glaysher
piman: x11 review ben: owners stamp for all the files I added trace event calls ...
7 years, 1 month ago (2013-11-04 20:32:42 UTC) #1
Ben Goodger (Google)
trace events lgtm
7 years, 1 month ago (2013-11-04 20:39:16 UTC) #2
piman
lgtm
7 years, 1 month ago (2013-11-04 20:46:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/56053005/230001
7 years, 1 month ago (2013-11-05 00:24:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/56053005/230001
7 years, 1 month ago (2013-11-05 03:19:21 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=219405
7 years, 1 month ago (2013-11-05 06:48:34 UTC) #6
Elliot Glaysher
7 years, 1 month ago (2013-11-05 18:33:53 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r233035 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698