Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 56053004: Dispatches touch events to captured window (Closed)

Created:
7 years, 1 month ago by sky
Modified:
7 years, 1 month ago
Reviewers:
ananta
CC:
chromium-reviews, tfarina, ben+views_chromium.org, ben+corewm_chromium.org
Visibility:
Public.

Description

Dispatches touch events to captured window We were doing this before I switched us back to the per window CaptureClient. We need this since current code assumes SetCapture captures both mouse and touch events. This also turned up a bug in CompoundEventFilter. It may end up showing the cursor on the wrong root, resulting in the cursor remaining hidden. As we don't need the cursor hiding logic on windows I'm turning it off for us (windows hides the cursor for us). TEST=see bug BUG=311569 R=ananta@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232662

Patch Set 1 #

Patch Set 2 : comment #

Patch Set 3 : lookup from captured window #

Patch Set 4 : update tests #

Patch Set 5 : disable test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -6 lines) Patch
M ash/wm/window_manager_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/corewm/compound_event_filter.cc View 1 2 3 4 chunks +19 lines, -3 lines 0 comments Download
M ui/views/corewm/compound_event_filter_unittest.cc View 1 2 3 4 2 chunks +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_root_window_host_win.cc View 1 2 3 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
sky
7 years, 1 month ago (2013-11-02 00:03:42 UTC) #1
ananta
lgtm
7 years, 1 month ago (2013-11-02 00:19:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/56053004/50001
7 years, 1 month ago (2013-11-02 00:43:00 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=217934
7 years, 1 month ago (2013-11-02 02:33:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/56053004/310001
7 years, 1 month ago (2013-11-02 18:18:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/56053004/310001
7 years, 1 month ago (2013-11-02 19:37:05 UTC) #6
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) views_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=96854
7 years, 1 month ago (2013-11-02 20:38:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/56053004/610001
7 years, 1 month ago (2013-11-02 21:02:29 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests, chrome_frame_net_tests, chrome_frame_tests, chrome_frame_unittests, content_browsertests, mini_installer_test, ...
7 years, 1 month ago (2013-11-03 00:45:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/56053004/610001
7 years, 1 month ago (2013-11-03 02:16:04 UTC) #10
commit-bot: I haz the power
7 years, 1 month ago (2013-11-03 04:52:15 UTC) #11
Message was sent while issue was closed.
Change committed as 232662

Powered by Google App Engine
This is Rietveld 408576698