Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 56053003: Improve error handling and revert old debugging code. (Closed)

Created:
7 years, 1 month ago by DaleCurtis
Modified:
7 years, 1 month ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Improve error handling and revert old debugging code. This pulls out some of the extra debugging code I've added for the debug builds I've been handing out. Specifically: - Checks error status on Start() and Stop(). - Ensures preconfigured AudioBus channel count matches buffer list count. - Removes old debugging code that is never triggered. BUG=160920 TEST=none R=scherkus@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232796

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -22 lines) Patch
M media/audio/mac/audio_auhal_mac.cc View 7 chunks +22 lines, -18 lines 0 comments Download
M media/audio/mac/audio_manager_mac.h View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
DaleCurtis
7 years, 1 month ago (2013-11-01 23:13:08 UTC) #1
scherkus (not reviewing)
lgtm
7 years, 1 month ago (2013-11-04 18:49:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/56053003/1
7 years, 1 month ago (2013-11-04 18:59:42 UTC) #3
DaleCurtis
Committed patchset #1 manually as r232796 (presubmit successful).
7 years, 1 month ago (2013-11-04 21:12:31 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-11-04 21:15:17 UTC) #5
Message was sent while issue was closed.
Retried try job too often on win_rel for step(s) chrome_frame_tests,
content_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698