runtime/bin/vmservice/observatory/lib/src/elements/object_common.html - Issue 560503002: Add support for TokenStream, LocalVarDescriptors, and PcDescriptors to service lib and generic obje…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/observatory/lib/src/elements/object_common.html

Issue 560503002: Add support for TokenStream, LocalVarDescriptors, and PcDescriptors to service lib and generic obje… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/bin/vmservice/observatory/lib/elements.html ('k') | runtime/bin/vmservice/observatory/lib/src/elements/object_view.dart » ('j') | runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/bin/vmservice/observatory/lib/src/elements/object_common.html

diff --git a/runtime/bin/vmservice/observatory/lib/src/elements/object_common.html b/runtime/bin/vmservice/observatory/lib/src/elements/object_common.html

index 63c78a17021ae2f129644778b122c69a15722be5..28eb801ae24de05225b6b8637ded569a723ae20a 100644

--- a/runtime/bin/vmservice/observatory/lib/src/elements/object_common.html

+++ b/runtime/bin/vmservice/observatory/lib/src/elements/object_common.html

@@ -14,17 +14,21 @@

- <div class="memberItem">

- <div class="memberName">class</div>

- <div class="memberValue">

- <class-ref ref="{{ object.clazz }}"></class-ref>

+ <template if="{{ object.clazz != null }}">

rmacnak 2014/09/09 20:36:31 An object should always have a class and size.

Cutch 2014/09/10 19:59:20 Acknowledged.

+ <div class="memberItem">

+ <div class="memberName">class</div>

+ <div class="memberValue">

+ <class-ref ref="{{ object.clazz }}"></class-ref>

+ </div>

</div>

- </div>

+ </template>

- <div class="memberItem" title="Space for this object in memory">

- <div class="memberName">size</div>

- <div class="memberValue">{{ object.size | formatSize }}</div>

- </div>

+ <template if="{{ object.size != null }}">

+ <div class="memberItem" title="Space for this object in memory">

+ <div class="memberName">size</div>

+ <div class="memberValue">{{ object.size | formatSize }}</div>

+ </div>

turnidge 2014/09/09 19:30:24 I wonder if these should move to some sort of "ins

Cutch 2014/09/10 19:59:20 Acknowledged.

+ </template>

<div class="memberName">retained size</div>