Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 560493002: Subzero: The cross tests should use the actual Subzero runtime. (Closed)

Created:
6 years, 3 months ago by Jim Stichnoth
Modified:
6 years, 3 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Subzero: The cross tests should use the actual Subzero runtime. BUG= none R=jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=6d4f564

Patch Set 1 #

Total comments: 2

Patch Set 2 : Make the g++/clang++ comment correct #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -29 lines) Patch
M crosstest/test_cast_main.cpp View 1 chunk +0 lines, -20 lines 0 comments Download
M crosstest/test_vector_ops_main.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M pydir/crosstest.py View 2 chunks +6 lines, -1 line 0 comments Download
A runtime/szrt.cpp View 1 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Jim Stichnoth
6 years, 3 months ago (2014-09-09 18:44:15 UTC) #2
jvoung (off chromium)
lgtm https://codereview.chromium.org/560493002/diff/1/runtime/szrt.cpp File runtime/szrt.cpp (right): https://codereview.chromium.org/560493002/diff/1/runtime/szrt.cpp#newcode10 runtime/szrt.cpp:10: // This file is a C++ wrapper to ...
6 years, 3 months ago (2014-09-09 21:19:33 UTC) #3
Jim Stichnoth
https://codereview.chromium.org/560493002/diff/1/runtime/szrt.cpp File runtime/szrt.cpp (right): https://codereview.chromium.org/560493002/diff/1/runtime/szrt.cpp#newcode10 runtime/szrt.cpp:10: // This file is a C++ wrapper to szrt.c ...
6 years, 3 months ago (2014-09-09 21:40:45 UTC) #4
Jim Stichnoth
6 years, 3 months ago (2014-09-09 21:40:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 6d4f564 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698