Issue 560463002: Fix ElementsKind handling of prototypes in Array.concat

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 560463002: Fix ElementsKind handling of prototypes in Array.concat (Closed)

Created:
6 years, 3 months ago by Jakob Kummerow

Modified:
6 years, 3 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Fix ElementsKind handling of prototypes in Array.concat Double elements, typed elements, and sloppy arguments elements were all erroneously marked UNREACHABLE. BUG=chromium:412203 LOG=n R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23863

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -19 lines)			Patch
	M	src/runtime.cc	View		3 chunks	+31 lines, -19 lines	0 comments	Download
	A	test/mjsunit/regress/regress-crbug-412203.js	View		1 chunk	+31 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Jakob Kummerow

6 years, 3 months ago (2014-09-11 10:04:22 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 23863 (presubmit successful).