Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 560393003: Do not allow values to be migrated without MACs if the destination already has a MAC. (Closed)

Created:
6 years, 3 months ago by gab
Modified:
6 years, 3 months ago
Reviewers:
gab
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2062_120
Project:
chromium
Visibility:
Public.

Description

Do not allow values to be migrated without MACs if the destination already has a MAC. BUG=414554 TEST=Added regression test PrefHashBrowserTestUntrustedAdditionToPrefs which fails without this CL and passes with it. Review URL: https://codereview.chromium.org/550343004 Cr-Commit-Position: refs/heads/master@{#295048} (cherry picked from commit b004a56cd18f7519d1cceafb534a5865f93d988d) Conflicts: (DNE in 37; test running on trunk and beta-builders is sufficient) chrome/browser/prefs/tracked/pref_hash_browsertest.cc TBR=gab@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/39f8a1461d36f9f8f749bf59071a8a194f6569e2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chrome/browser/prefs/tracked/tracked_preferences_migration.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
gab
6 years, 3 months ago (2014-09-18 00:56:45 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 39f8a14 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698