Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 560353003: use OVERRIDE macro consistently in quic (Closed)

Created:
6 years, 3 months ago by Mostyn Bramley-Moore
Modified:
6 years, 2 months ago
Reviewers:
wtc, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

use OVERRIDE macro consistently in quic Followup to 475113005, use OVERRIDE macro instead of using override directly. Committed: https://crrev.com/5b6be1c953640abfda4fdeefc05261b8104b89ae Cr-Commit-Position: refs/heads/master@{#294503}

Patch Set 1 #

Patch Set 2 : another one #

Patch Set 3 : and some more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M net/quic/test_tools/quic_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/test_tools/quic_test_utils.h View 1 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/test_tools/quic_test_utils.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Mostyn Bramley-Moore
@Ryan: can you please OK this?
6 years, 3 months ago (2014-09-11 20:35:22 UTC) #2
Ryan Hamilton
lgtm
6 years, 3 months ago (2014-09-11 20:37:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/560353003/40001
6 years, 3 months ago (2014-09-11 20:59:01 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001) as c026eb9794f36773c03352615fdbed06ab52e340
6 years, 3 months ago (2014-09-12 00:37:54 UTC) #6
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/5b6be1c953640abfda4fdeefc05261b8104b89ae Cr-Commit-Position: refs/heads/master@{#294503}
6 years, 3 months ago (2014-09-12 00:44:16 UTC) #7
wtc
6 years, 2 months ago (2014-09-29 23:15:23 UTC) #8
Message was sent while issue was closed.
Patch set 3 LGTM.

The files in net/tools/quic are only compiled on Linux right now, which is why
they could get by without using the OVERRIDE macro.

Powered by Google App Engine
This is Rietveld 408576698