Avoid more temporary ranges in connection with various TextIterators.

Avoid more temporary ranges in connection with various TextIterators.

Rename the range method to createRange and remove it from the classes
where we have gotten rid of all uses.

R=yosin@chromium.org
BUG=388681
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181974

[yosin_UTC9, 2014-09-12 01:02:24]

LGTM

Since I'm fan of functional programming, |StartPositionAndEndPosition| struct
(or |ImmutableRange|) attract me for replacing in/out parameters,
VisibleSelection::toNormalizePositions(inout_start, inout_end),
Range::selecteNodes(intout_start, inout_end).

I may want to visit |ImmutableRange| once we get rid of all temporary |Range|
objects.

https://codereview.chromium.org/560333002/diff/1/Source/core/accessibility/AX...
File Source/core/accessibility/AXRenderObject.cpp (right):

https://codereview.chromium.org/560333002/diff/1/Source/core/accessibility/AX...
Source/core/accessibility/AXRenderObject.cpp:1742: bool selected =
Range::selectNodeContents(node, start, end);
It seems utilizing |selected| makes cleaner.

if (!Range::selectNodeContens(...)) 
  return VisiblePosition();

https://codereview.chromium.org/560333002/diff/1/Source/core/editing/TextIter...
File Source/core/editing/TextIterator.cpp (right):

https://codereview.chromium.org/560333002/diff/1/Source/core/editing/TextIter...
Source/core/editing/TextIterator.cpp:1801: if (!m_textIterator.atEnd()) {
ACK: This change is imported from http://crrev.com/560653003

https://codereview.chromium.org/560333002/diff/1/Source/core/html/HTMLTextFor...
File Source/core/html/HTMLTextFormControlElement.cpp (right):

https://codereview.chromium.org/560333002/diff/1/Source/core/html/HTMLTextFor...
Source/core/html/HTMLTextFormControlElement.cpp:397: bool selected =
Range::selectNodeContents(innerEditorElement(), start, end);
It seems utilizing |selected| makes cleaner.

if (!Range::selectNodeContens(...)) 
  return VisiblePosition();

[Mads Ager (chromium), 2014-09-12 10:52:09]

Thanks for the review.

I agree that some of this could be revisited once we get rid of the temporary
ranges.

https://codereview.chromium.org/560333002/diff/1/Source/core/accessibility/AX...
File Source/core/accessibility/AXRenderObject.cpp (right):

https://codereview.chromium.org/560333002/diff/1/Source/core/accessibility/AX...
Source/core/accessibility/AXRenderObject.cpp:1742: bool selected =
Range::selectNodeContents(node, start, end);
On 2014/09/12 01:02:24, Yosi_UTC9 wrote:
> It seems utilizing |selected| makes cleaner.
> 
> if (!Range::selectNodeContens(...)) 
>   return VisiblePosition();

Done.

https://codereview.chromium.org/560333002/diff/1/Source/core/editing/TextIter...
File Source/core/editing/TextIterator.cpp (right):

https://codereview.chromium.org/560333002/diff/1/Source/core/editing/TextIter...
Source/core/editing/TextIterator.cpp:1801: if (!m_textIterator.atEnd()) {
On 2014/09/12 01:02:24, Yosi_UTC9 wrote:
> ACK: This change is imported from http://crrev.com/560653003

Yes. :)

https://codereview.chromium.org/560333002/diff/1/Source/core/html/HTMLTextFor...
File Source/core/html/HTMLTextFormControlElement.cpp (right):

https://codereview.chromium.org/560333002/diff/1/Source/core/html/HTMLTextFor...
Source/core/html/HTMLTextFormControlElement.cpp:397: bool selected =
Range::selectNodeContents(innerEditorElement(), start, end);
On 2014/09/12 01:02:24, Yosi_UTC9 wrote:
> It seems utilizing |selected| makes cleaner.
> 
> if (!Range::selectNodeContens(...)) 
>   return VisiblePosition();

Done.

[Mads Ager (chromium), 2014-09-12 10:52:20]

The CQ bit was checked by ager@chromium.org

[commit-bot: I haz the power, 2014-09-12 10:52:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/560333002/20001

[commit-bot: I haz the power, 2014-09-12 11:04:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-12 11:04:19]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/23181)

[Mads Ager (chromium), 2014-09-12 11:50:50]

ager@chromium.org changed reviewers:
+ tkent@chromium.org

[Mads Ager (chromium), 2014-09-12 11:50:51]

Kent, could you have a look at the trivial change in web/

[Mads Ager (chromium), 2014-09-15 08:25:57]

ager@chromium.org changed reviewers:
+ jochen@chromium.org

[Mads Ager (chromium), 2014-09-15 08:26:29]

Kent or Jochen, could one of you have a quick look at the trivial web/ change?
Thanks!

[jochen (gone - plz use gerrit), 2014-09-15 12:26:07]

lgtm

[Mads Ager (chromium), 2014-09-15 12:27:18]

The CQ bit was checked by ager@chromium.org

[commit-bot: I haz the power, 2014-09-15 12:28:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/560333002/40001

[commit-bot: I haz the power, 2014-09-15 12:40:19]

Committed patchset #3 (id:40001) as 181974