Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1683)

Unified Diff: content/shell/browser/shell_devtools_delegate.h

Issue 560323005: [DevTools] Move target-related methods from DevToolsHttpHandlerDelegate to DevToolsManagerDelegate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/browser/shell_devtools_delegate.h
diff --git a/content/shell/browser/shell_devtools_delegate.h b/content/shell/browser/shell_devtools_delegate.h
index f200ed1f40b7a77a6dfcde4240ca465f9c7c4c0e..e03c7593b0919b4cda4ae94ef0e312f90c769604 100644
--- a/content/shell/browser/shell_devtools_delegate.h
+++ b/content/shell/browser/shell_devtools_delegate.h
@@ -8,6 +8,7 @@
#include "base/basictypes.h"
#include "base/compiler_specific.h"
#include "content/public/browser/devtools_http_handler_delegate.h"
+#include "content/public/browser/devtools_manager_delegate.h"
namespace content {
@@ -22,13 +23,10 @@ class ShellDevToolsDelegate : public DevToolsHttpHandlerDelegate {
// Stops http server.
void Stop();
- // DevToolsHttpProtocolHandler::Delegate overrides.
+ // DevToolsHttpHandlerDelegate implementation.
virtual std::string GetDiscoveryPageHTML() OVERRIDE;
virtual bool BundlesFrontendResources() OVERRIDE;
virtual base::FilePath GetDebugFrontendDir() OVERRIDE;
- virtual std::string GetPageThumbnailData(const GURL& url) OVERRIDE;
- virtual scoped_ptr<DevToolsTarget> CreateNewTarget(const GURL& url) OVERRIDE;
- virtual void EnumerateTargets(TargetCallback callback) OVERRIDE;
virtual scoped_ptr<net::StreamListenSocket> CreateSocketForTethering(
net::StreamListenSocket::Delegate* delegate,
std::string* name) OVERRIDE;
@@ -44,6 +42,29 @@ class ShellDevToolsDelegate : public DevToolsHttpHandlerDelegate {
DISALLOW_COPY_AND_ASSIGN(ShellDevToolsDelegate);
};
+class ShellDevToolsManagerDelegate : public DevToolsManagerDelegate {
+ public:
+ explicit ShellDevToolsManagerDelegate(BrowserContext* browser_context);
+ virtual ~ShellDevToolsManagerDelegate();
+
+ // DevToolsManagerDelegate implementation.
+ virtual void Inspect(BrowserContext* browser_context,
+ DevToolsAgentHost* agent_host) OVERRIDE {}
+ virtual void DevToolsAgentStateChanged(DevToolsAgentHost* agent_host,
+ bool attached) OVERRIDE {}
+ virtual base::DictionaryValue* HandleCommand(
+ DevToolsAgentHost* agent_host,
+ base::DictionaryValue* command) OVERRIDE;
+ virtual scoped_ptr<DevToolsTarget> CreateNewTarget(const GURL& url) OVERRIDE;
+ virtual void EnumerateTargets(TargetCallback callback) OVERRIDE;
+ virtual std::string GetPageThumbnailData(const GURL& url) OVERRIDE;
+
+ private:
+ BrowserContext* browser_context_;
+
+ DISALLOW_COPY_AND_ASSIGN(ShellDevToolsManagerDelegate);
+};
+
} // namespace content
#endif // CONTENT_SHELL_BROWSER_SHELL_DEVTOOLS_DELEGATE_H_
« no previous file with comments | « content/shell/browser/shell_content_browser_client.cc ('k') | content/shell/browser/shell_devtools_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698