Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: chromecast/shell/browser/devtools/cast_dev_tools_delegate.h

Issue 560323005: [DevTools] Move target-related methods from DevToolsHttpHandlerDelegate to DevToolsManagerDelegate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/shell/browser/devtools/cast_dev_tools_delegate.h
diff --git a/chromecast/shell/browser/devtools/cast_dev_tools_delegate.h b/chromecast/shell/browser/devtools/cast_dev_tools_delegate.h
index e41e1a85bd0811b868378377a39155a34968abe7..c1801591056f7da3d4dc9218d46e9cd02af1d77e 100644
--- a/chromecast/shell/browser/devtools/cast_dev_tools_delegate.h
+++ b/chromecast/shell/browser/devtools/cast_dev_tools_delegate.h
@@ -6,12 +6,17 @@
#define CHROMECAST_SHELL_BROWSER_DEVTOOLS_CAST_DEV_TOOLS_DELEGATE_H_
#include "content/public/browser/devtools_http_handler_delegate.h"
+#include "content/public/browser/devtools_manager_delegate.h"
#include "net/socket/stream_listen_socket.h"
namespace base {
class FilePath;
}
+namespace content {
+class BrowserContext;
+}
+
namespace chromecast {
namespace shell {
@@ -24,10 +29,6 @@ class CastDevToolsDelegate : public content::DevToolsHttpHandlerDelegate {
virtual std::string GetDiscoveryPageHTML() OVERRIDE;
virtual bool BundlesFrontendResources() OVERRIDE;
virtual base::FilePath GetDebugFrontendDir() OVERRIDE;
- virtual std::string GetPageThumbnailData(const GURL& url) OVERRIDE;
- virtual scoped_ptr<content::DevToolsTarget> CreateNewTarget(
- const GURL& url) OVERRIDE;
- virtual void EnumerateTargets(TargetCallback callback) OVERRIDE;
virtual scoped_ptr<net::StreamListenSocket> CreateSocketForTethering(
net::StreamListenSocket::Delegate* delegate,
std::string* name) OVERRIDE;
@@ -36,6 +37,30 @@ class CastDevToolsDelegate : public content::DevToolsHttpHandlerDelegate {
DISALLOW_COPY_AND_ASSIGN(CastDevToolsDelegate);
};
+class CastDevToolsManagerDelegate : public content::DevToolsManagerDelegate {
+ public:
+ CastDevToolsManagerDelegate();
+ virtual ~CastDevToolsManagerDelegate();
+
+ // DevToolsManagerDelegate implementation.
+ virtual void Inspect(
+ content::BrowserContext* browser_context,
+ content::DevToolsAgentHost* agent_host) OVERRIDE {}
+ virtual void DevToolsAgentStateChanged(
+ content::DevToolsAgentHost* agent_host,
+ bool attached) OVERRIDE {}
+ virtual base::DictionaryValue* HandleCommand(
+ content::DevToolsAgentHost* agent_host,
+ base::DictionaryValue* command) OVERRIDE;
+ virtual scoped_ptr<content::DevToolsTarget> CreateNewTarget(
+ const GURL& url) OVERRIDE;
+ virtual void EnumerateTargets(TargetCallback callback) OVERRIDE;
+ virtual std::string GetPageThumbnailData(const GURL& url) OVERRIDE;
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(CastDevToolsManagerDelegate);
+};
+
} // namespace shell
} // namespace chromecast
« no previous file with comments | « chromecast/shell/browser/cast_content_browser_client.cc ('k') | chromecast/shell/browser/devtools/cast_dev_tools_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698