chromecast/shell/browser/cast_content_browser_client.cc - Issue 560323005: [DevTools] Move target-related methods from DevToolsHttpHandlerDelegate to DevToolsManagerDelegate.

Unified Diff: chromecast/shell/browser/cast_content_browser_client.cc

Issue 560323005: [DevTools] Move target-related methods from DevToolsHttpHandlerDelegate to DevToolsManagerDelegate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased, fixed nit Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/dev_tools_manager_delegate_android.cc ('K') | « chromecast/shell/browser/cast_content_browser_client.h ('k') | chromecast/shell/browser/devtools/cast_dev_tools_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromecast/shell/browser/cast_content_browser_client.cc

diff --git a/chromecast/shell/browser/cast_content_browser_client.cc b/chromecast/shell/browser/cast_content_browser_client.cc

index af3993b3b27ed0d986217092b15e7e58ca042d6f..68281b6294477fcb2bae0aee1158447fe8e7d598 100644

--- a/chromecast/shell/browser/cast_content_browser_client.cc

+++ b/chromecast/shell/browser/cast_content_browser_client.cc

@@ -12,6 +12,7 @@

#include "chromecast/shell/browser/cast_browser_context.h"

#include "chromecast/shell/browser/cast_browser_main_parts.h"

#include "chromecast/shell/browser/cast_browser_process.h"

+#include "chromecast/shell/browser/devtools/cast_dev_tools_delegate.h"

#include "chromecast/shell/browser/geolocation/cast_access_token_store.h"

#include "chromecast/shell/browser/url_request_context_factory.h"

#include "content/public/browser/browser_thread.h"

@@ -149,6 +150,11 @@ bool CastContentBrowserClient::CanCreateWindow(

return false;

}

+content::DevToolsManagerDelegate*

+CastContentBrowserClient::GetDevToolsManagerDelegate() {

+ return new CastDevToolsManagerDelegate();

gunsch 2014/09/19 15:48:32 How does this affect the availability of remote de

dgozman 2014/09/19 16:31:38 This has no effect on remote debugging. DevToolsHt

void CastContentBrowserClient::GetAdditionalMappedFilesForChildProcess(

const base::CommandLine& command_line,

int child_process_id,