content/browser/devtools/devtools_http_handler_unittest.cc - Issue 560323005: [DevTools] Move target-related methods from DevToolsHttpHandlerDelegate to DevToolsManagerDelegate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/devtools_http_handler_unittest.cc

Issue 560323005: [DevTools] Move target-related methods from DevToolsHttpHandlerDelegate to DevToolsManagerDelegate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chrome_content_browser_client.cc ('K') | « content/browser/devtools/devtools_http_handler_impl.cc ('k') | content/public/browser/devtools_http_handler_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/devtools_http_handler_unittest.cc

diff --git a/content/browser/devtools/devtools_http_handler_unittest.cc b/content/browser/devtools/devtools_http_handler_unittest.cc

index 16c820c063e046b944dec6d29aed795c6122382e..c0e65892805b5da1146f6c98651031b927e30267 100644

--- a/content/browser/devtools/devtools_http_handler_unittest.cc

+++ b/content/browser/devtools/devtools_http_handler_unittest.cc

@@ -86,18 +86,6 @@ class DummyDelegate : public DevToolsHttpHandlerDelegate {

return base::FilePath();

}

- virtual std::string GetPageThumbnailData(const GURL& url) OVERRIDE {

- return std::string();

- }

- virtual scoped_ptr<DevToolsTarget> CreateNewTarget(const GURL& url) OVERRIDE {

- return scoped_ptr<DevToolsTarget>();

- }

- virtual void EnumerateTargets(TargetCallback callback) OVERRIDE {

- callback.Run(TargetList());

- }

virtual scoped_ptr<net::StreamListenSocket> CreateSocketForTethering(

net::StreamListenSocket::Delegate* delegate,

std::string* name) OVERRIDE {