Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: content/public/browser/devtools_manager_delegate.h

Issue 560323005: [DevTools] Move target-related methods from DevToolsHttpHandlerDelegate to DevToolsManagerDelegate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/devtools_manager_delegate.h
diff --git a/content/public/browser/devtools_manager_delegate.h b/content/public/browser/devtools_manager_delegate.h
index d34e7af3957ed5eea0cc835fb73cb348f45b4f4c..249cfea37e7dfc0e168f98854c8c8b17907a8819 100644
--- a/content/public/browser/devtools_manager_delegate.h
+++ b/content/public/browser/devtools_manager_delegate.h
@@ -5,14 +5,19 @@
#ifndef CONTENT_PUBLIC_BROWSER_DEVTOOLS_MANAGER_DELEGATE_H_
#define CONTENT_PUBLIC_BROWSER_DEVTOOLS_MANAGER_DELEGATE_H_
+#include "base/callback.h"
+
namespace base {
class DictionaryValue;
}
+class GURL;
+
namespace content {
class BrowserContext;
class DevToolsAgentHost;
+class DevToolsTarget;
class DevToolsManagerDelegate {
public:
@@ -29,6 +34,20 @@ class DevToolsManagerDelegate {
virtual base::DictionaryValue* HandleCommand(
DevToolsAgentHost* agent_host,
base::DictionaryValue* command) = 0;
+
+ // Creates new inspectable target.
+ virtual scoped_ptr<DevToolsTarget> CreateNewTarget(const GURL& url) = 0;
+
+ typedef std::vector<DevToolsTarget*> TargetList;
+ typedef base::Callback<void(const TargetList&)> TargetCallback;
+
+ // Requests the list of all inspectable targets.
+ // The caller gets the ownership of the returned targets.
+ virtual void EnumerateTargets(TargetCallback callback) = 0;
+
+ // Get a thumbnail for a given page. Returns non-empty string iff we have the
+ // thumbnail.
+ virtual std::string GetPageThumbnailData(const GURL& url) = 0;
};
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698