chrome/browser/chrome_content_browser_client.cc - Issue 560323005: [DevTools] Move target-related methods from DevToolsHttpHandlerDelegate to DevToolsManagerDelegate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 560323005: [DevTools] Move target-related methods from DevToolsHttpHandlerDelegate to DevToolsManagerDelegate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/browser/aw_dev_tools_manager_delegate.cc ('K') | « chrome/browser/android/dev_tools_server.cc ('k') | chrome/browser/devtools/browser_list_tabcontents_provider.h » ('j') | chrome/browser/devtools/chrome_devtools_manager_delegate.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chrome_content_browser_client.cc

diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc

index 7418ac35eaa7925aabdf9c569a610f09500d98e1..c0392d45bd7612c5456679eab6aa9228c975f859 100644

--- a/chrome/browser/chrome_content_browser_client.cc

+++ b/chrome/browser/chrome_content_browser_client.cc

@@ -151,6 +151,7 @@

#elif defined(OS_LINUX)

#include "chrome/browser/chrome_browser_main_linux.h"

#elif defined(OS_ANDROID)

+#include "chrome/browser/android/dev_tools_manager_delegate_android.h"

#include "chrome/browser/android/new_tab_page_url_handler.h"

#include "chrome/browser/android/webapps/single_tab_mode_tab_helper.h"

#include "chrome/browser/chrome_browser_main_android.h"

@@ -2503,7 +2504,11 @@ bool ChromeContentBrowserClient::CheckMediaAccessPermission(

content::DevToolsManagerDelegate*

ChromeContentBrowserClient::GetDevToolsManagerDelegate() {

+#if defined(OS_ANDROID)

+ return new DevToolsManagerDelegateAndroid();

+#else

return new ChromeDevToolsManagerDelegate();

+#endif

}

bool ChromeContentBrowserClient::IsPluginAllowedToCallRequestOSFileHandle(