Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: build/common.gypi

Issue 560323004: Another attempt to fix debug info stripping for ASan on OSX (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase after landing default options for ASan Mac Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 07aed489acb9c77e29929adcb73f1f06ca5d687c..f0589e05fe79db8a8fa7c49bccfbb443bb1fc753 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -2154,7 +2154,7 @@
['asan==1 and OS=="mac"', {
# TODO(glider): we do not strip ASan binaries until the dynamic ASan
# runtime is fully adopted. See http://crbug.com/242503.
- 'mac_strip_release': 0,
+ 'mac_strip_release': 1,
}],
['tsan==1', {
'use_custom_libcxx%': 1,
@@ -5001,10 +5001,10 @@
'conditions': [
['asan==1', {
'variables': {
- 'asan_saves_file': 'asan.saves',
+ 'asan_saves_file_path': 'asan.saves',
},
'xcode_settings': {
- 'CHROMIUM_STRIP_SAVE_FILE': '<(asan_saves_file)',
+ 'CHROMIUM_STRIP_SAVE_FILE': '<(asan_saves_file_path)',
},
}],
],
@@ -5051,7 +5051,7 @@
'conditions': [
['asan==1', {
'STRIPFLAGS': '-s $(CHROMIUM_STRIP_SAVE_FILE)',
- }]
+ }],
],
}], # _type=="executable" and asan==1
], # target_conditions
« build/asan.saves ('K') | « build/asan.saves ('k') | chrome/app/app_asan.saves » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698