Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Side by Side Diff: build/common.gypi

Issue 560323004: Another attempt to fix debug info stripping for ASan on OSX (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase after landing default options for ASan Mac Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 2136 matching lines...) Expand 10 before | Expand all | Expand 10 after
2147 }], 2147 }],
2148 ['ubsan==1', { 2148 ['ubsan==1', {
2149 'clang%': 1, 2149 'clang%': 1,
2150 }], 2150 }],
2151 ['ubsan_vptr==1', { 2151 ['ubsan_vptr==1', {
2152 'clang%': 1, 2152 'clang%': 1,
2153 }], 2153 }],
2154 ['asan==1 and OS=="mac"', { 2154 ['asan==1 and OS=="mac"', {
2155 # TODO(glider): we do not strip ASan binaries until the dynamic ASan 2155 # TODO(glider): we do not strip ASan binaries until the dynamic ASan
2156 # runtime is fully adopted. See http://crbug.com/242503. 2156 # runtime is fully adopted. See http://crbug.com/242503.
2157 'mac_strip_release': 0, 2157 'mac_strip_release': 1,
2158 }], 2158 }],
2159 ['tsan==1', { 2159 ['tsan==1', {
2160 'use_custom_libcxx%': 1, 2160 'use_custom_libcxx%': 1,
2161 }], 2161 }],
2162 ['msan==1', { 2162 ['msan==1', {
2163 # Use a just-built, MSan-instrumented libc++ instead of the system-wide 2163 # Use a just-built, MSan-instrumented libc++ instead of the system-wide
2164 # libstdc++. This is required to avoid false positive reports whenever 2164 # libstdc++. This is required to avoid false positive reports whenever
2165 # the C++ standard library is used. 2165 # the C++ standard library is used.
2166 'use_custom_libcxx%': 1, 2166 'use_custom_libcxx%': 1,
2167 # Running the V8-generated code on an ARM simulator is a powerful hack 2167 # Running the V8-generated code on an ARM simulator is a powerful hack
(...skipping 2826 matching lines...) Expand 10 before | Expand all | Expand 10 after
4994 'postbuild_name': 'Change Mach-O Flags', 4994 'postbuild_name': 'Change Mach-O Flags',
4995 'action': [ 4995 'action': [
4996 '<(change_mach_o_flags_path)', 4996 '<(change_mach_o_flags_path)',
4997 '>@(change_mach_o_flags_options)', 4997 '>@(change_mach_o_flags_options)',
4998 ], 4998 ],
4999 }, 4999 },
5000 ], 5000 ],
5001 'conditions': [ 5001 'conditions': [
5002 ['asan==1', { 5002 ['asan==1', {
5003 'variables': { 5003 'variables': {
5004 'asan_saves_file': 'asan.saves', 5004 'asan_saves_file_path': 'asan.saves',
5005 }, 5005 },
5006 'xcode_settings': { 5006 'xcode_settings': {
5007 'CHROMIUM_STRIP_SAVE_FILE': '<(asan_saves_file)', 5007 'CHROMIUM_STRIP_SAVE_FILE': '<(asan_saves_file_path)',
5008 }, 5008 },
5009 }], 5009 }],
5010 ], 5010 ],
5011 'target_conditions': [ 5011 'target_conditions': [
5012 ['mac_pie==1 and release_valgrind_build==0', { 5012 ['mac_pie==1 and release_valgrind_build==0', {
5013 # Turn on position-independence (ASLR) for executables. When 5013 # Turn on position-independence (ASLR) for executables. When
5014 # PIE is on for the Chrome executables, the framework will 5014 # PIE is on for the Chrome executables, the framework will
5015 # also be subject to ASLR. 5015 # also be subject to ASLR.
5016 # Don't do this when building for Valgrind, because Valgrind 5016 # Don't do this when building for Valgrind, because Valgrind
5017 # doesn't understand slide. TODO: Make Valgrind on Mac OS X 5017 # doesn't understand slide. TODO: Make Valgrind on Mac OS X
(...skipping 26 matching lines...) Expand all
5044 # only (-S). Local symbols should be stripped as 5044 # only (-S). Local symbols should be stripped as
5045 # well, which will be handled by -x. Xcode will 5045 # well, which will be handled by -x. Xcode will
5046 # continue to insert -S when stripping even when 5046 # continue to insert -S when stripping even when
5047 # additional flags are added with STRIPFLAGS. 5047 # additional flags are added with STRIPFLAGS.
5048 'STRIPFLAGS': '-x', 5048 'STRIPFLAGS': '-x',
5049 }], # _type=="shared_library" or _type=="loadable_modul e" 5049 }], # _type=="shared_library" or _type=="loadable_modul e"
5050 ['_type=="executable"', { 5050 ['_type=="executable"', {
5051 'conditions': [ 5051 'conditions': [
5052 ['asan==1', { 5052 ['asan==1', {
5053 'STRIPFLAGS': '-s $(CHROMIUM_STRIP_SAVE_FILE)', 5053 'STRIPFLAGS': '-s $(CHROMIUM_STRIP_SAVE_FILE)',
5054 }] 5054 }],
5055 ], 5055 ],
5056 }], # _type=="executable" and asan==1 5056 }], # _type=="executable" and asan==1
5057 ], # target_conditions 5057 ], # target_conditions
5058 }, # xcode_settings 5058 }, # xcode_settings
5059 }, # configuration "Release" 5059 }, # configuration "Release"
5060 }, # configurations 5060 }, # configurations
5061 }, { # mac_real_dsym != 1 5061 }, { # mac_real_dsym != 1
5062 # To get a fast fake .dSYM bundle, use a post-build step to 5062 # To get a fast fake .dSYM bundle, use a post-build step to
5063 # produce the .dSYM and strip the executable. strip_from_xcode 5063 # produce the .dSYM and strip the executable. strip_from_xcode
5064 # only operates in the Release configuration. 5064 # only operates in the Release configuration.
(...skipping 713 matching lines...) Expand 10 before | Expand all | Expand 10 after
5778 # settings in target dicts. SYMROOT is a special case, because many other 5778 # settings in target dicts. SYMROOT is a special case, because many other
5779 # Xcode variables depend on it, including variables such as 5779 # Xcode variables depend on it, including variables such as
5780 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 5780 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
5781 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 5781 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
5782 # files to appear (when present) in the UI as actual files and not red 5782 # files to appear (when present) in the UI as actual files and not red
5783 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 5783 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
5784 # and therefore SYMROOT, needs to be set at the project level. 5784 # and therefore SYMROOT, needs to be set at the project level.
5785 'SYMROOT': '<(DEPTH)/xcodebuild', 5785 'SYMROOT': '<(DEPTH)/xcodebuild',
5786 }, 5786 },
5787 } 5787 }
OLDNEW
« build/asan.saves ('K') | « build/asan.saves ('k') | chrome/app/app_asan.saves » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698