chrome/browser/chromeos/drive/fileapi/file_system_backend_delegate.cc - Issue 560313002: Use ExternalFileSystemBackend in the DriveURLRequestJob.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/drive/fileapi/file_system_backend_delegate.cc

Issue 560313002: Use ExternalFileSystemBackend in the DriveURLRequestJob. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/drive/drive_url_request_job.cc ('K') | « chrome/browser/chromeos/drive/drive_url_request_job_unittest.cc ('k') | chrome/browser/chromeos/fileapi/file_system_backend.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/drive/fileapi/file_system_backend_delegate.cc

diff --git a/chrome/browser/chromeos/drive/fileapi/file_system_backend_delegate.cc b/chrome/browser/chromeos/drive/fileapi/file_system_backend_delegate.cc

index f153791fc2997e7662b45b0c276dca2bf91508c2..f46a01dc70393caa55da6fb9b1ebc394eb1f2ab9 100644

--- a/chrome/browser/chromeos/drive/fileapi/file_system_backend_delegate.cc

+++ b/chrome/browser/chromeos/drive/fileapi/file_system_backend_delegate.cc

@@ -56,6 +56,11 @@ void GetRedirectURLForContentsOnUIThread(

return;

}

const base::FilePath file_path = util::ExtractDrivePathFromFileSystemUrl(url);

+ if (file_path.empty()) {

+ callback.Run(GURL());

kinaba 2014/09/24 02:11:13 It looks you have to post to IO thread (as the !fi

hirono 2014/09/24 03:40:17 Thank you for catching it. Done.

+ return;

+ }

file_system->GetResourceEntry(

file_path,

base::Bind(&GetRedirectURLForContentsOnUIThreadWithResourceEntry,