Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 560303002: Remove unused user email argument from nss_util. (Closed)

Created:
6 years, 3 months ago by pneubeck (no reviews)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove unused user email argument from nss_util. BUG=413219 (for trivial refactoring) TBR=willchan@chromium.org,rsleevi@chromium.org,nkostylev@chromium.org Committed: https://crrev.com/fa32f2e56ac125ff2c95f35473f123a8d2bc2012 Cr-Commit-Position: refs/heads/master@{#294570}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -18 lines) Patch
M chrome/browser/chromeos/login/auth/chrome_cryptohome_authenticator.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/ownership/owner_settings_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/ownership/owner_settings_service.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M crypto/nss_util.cc View 2 chunks +6 lines, -10 lines 0 comments Download
M crypto/nss_util_internal.h View 1 chunk +0 lines, -1 line 0 comments Download
M crypto/scoped_test_nss_chromeos_user.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
pneubeck (no reviews)
ptal
6 years, 3 months ago (2014-09-11 12:57:40 UTC) #2
mattm
lgtm
6 years, 3 months ago (2014-09-11 21:36:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/560303002/20001
6 years, 3 months ago (2014-09-12 07:25:53 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/10564)
6 years, 3 months ago (2014-09-12 07:38:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/560303002/20001
6 years, 3 months ago (2014-09-12 09:50:04 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:20001) as 2483584d589ceeaf507d2f241fb95d10548a55ce
6 years, 3 months ago (2014-09-12 10:01:54 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fa32f2e56ac125ff2c95f35473f123a8d2bc2012 Cr-Commit-Position: refs/heads/master@{#294570}
6 years, 3 months ago (2014-09-12 10:07:57 UTC) #13
willchan no longer on Chromium
I consider this debatable as to whether or not it should be acceptable for TBR ...
6 years, 3 months ago (2014-09-15 22:46:26 UTC) #14
Ryan Sleevi
Ditto Will Ditto LGTM
6 years, 3 months ago (2014-09-15 23:31:33 UTC) #15
pneubeck (no reviews)
6 years, 3 months ago (2014-09-16 18:19:47 UTC) #16
Message was sent while issue was closed.
On 2014/09/15 22:46:26, willchan OOO until 03-22-15 wrote:
> I consider this debatable as to whether or not it should be acceptable for TBR
>
(http://www.chromium.org/developers/owners-files#TOC-When-to-use-To-Be-Reviewe...).
> It did not appear that burdensome to ask for a review, since it only touched a
> few places, rather than a hundred places across the code base. In the future,
I
> recommend getting a real review.
> 
> LGTM.

Thanks Will for speaking out instead of having a silent grunt on me.
Seems that I was a bit too careless in my judgement.
My thought was: "I got a review from Matt, who is one of the few who know this
code, and this refactoring is of mechanical nature. Why burden more people with
additional work?"

Rereading and rethinking the section about LGTM, I see my mistake and will not
repeat it.

Powered by Google App Engine
This is Rietveld 408576698