Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issue 5603005: Don't unescape backslashes in URLs, since these will be converted to slashes... (Closed)

Created:
7 years, 11 months ago by brettw
Modified:
7 years, 6 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Don't unescape backslashes in URLs, since these will be converted to slashes by googleurl, changing the meaning of the URL. BUG=45051 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68200

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M net/base/escape.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
7 years, 11 months ago (2010-12-03 17:40:08 UTC) #1
Peter Kasting
LGTM -- but have you considered making googleurl's conversion of \ to / be under ...
7 years, 11 months ago (2010-12-03 17:42:09 UTC) #2
brettw
7 years, 11 months ago (2010-12-03 17:52:18 UTC) #3
On Fri, Dec 3, 2010 at 9:42 AM,  <pkasting@chromium.org> wrote:
> LGTM -- but have you considered making googleurl's conversion of \ to / be
> under
> #if OS_WIN?

Yes, I think that's a bad idea. In general people don't know the
difference between / and \ so pages use them randomly in links. This
is why browsers generally convert them.

Brett

Powered by Google App Engine
This is Rietveld 408576698