Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Unified Diff: url/url_parse_unittest.cc

Issue 560283003: Wrong filename on file upload (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added unit testcases and modified code accordingly Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: url/url_parse_unittest.cc
diff --git a/url/url_parse_unittest.cc b/url/url_parse_unittest.cc
index a8b7f8541ef1138ac8a02b6671c35e4a50d2af62..35b31548467e05c49c0132bc0d5260bfc6789bf3 100644
--- a/url/url_parse_unittest.cc
+++ b/url/url_parse_unittest.cc
@@ -507,6 +507,11 @@ TEST(URLParser, ExtractFileName) {
{"http://www.google.com/foo/bar.html;param#ref", "bar.html"},
{"http://www.google.com/foo/bar.html;foo;param#ref", "bar.html;foo"},
{"http://www.google.com/foo/bar.html?query#ref", "bar.html"},
+ // Test cases added to verify Issue - 323156
brettw 2014/09/16 22:37:10 I don't think you need this comment. Can you add s
arun87.kumar 2014/09/17 11:39:12 Done.
+ {"http://www.google.com/foo;/bar.html", "bar.html"},
+ {"http://www.google.com/foo;/", ""},
+ {"http://www.google.com/foo;", "foo"},
+ {"http://www.google.com/;", ""},
};
for (size_t i = 0; i < ARRAYSIZE(file_cases); i++) {
« url/third_party/mozilla/url_parse.cc ('K') | « url/third_party/mozilla/url_parse.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698