Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 560273002: Fix possible race with batch updates in Files app. (Closed)

Created:
6 years, 3 months ago by mtomasz
Modified:
6 years, 3 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix possible race with batch updates in Files app. It's unlikely but possible that beginBatchUpdates() is executed on another list thatn endBatchUpdates(). As a result, one of the lists will become unusable. TEST=Tested manually with a fakely added delay for end-update-files. BUG=234039 Committed: https://crrev.com/8176b73b02e137a3c06afb7382a0a277338cc5ea Cr-Commit-Position: refs/heads/master@{#294545}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixed. #

Patch Set 3 : Cleanup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M ui/file_manager/file_manager/foreground/js/file_manager.js View 1 2 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
mtomasz
@hirono: PTAL. Thanks.
6 years, 3 months ago (2014-09-11 08:37:02 UTC) #2
hirono
https://codereview.chromium.org/560273002/diff/1/ui/file_manager/file_manager/foreground/js/file_manager.js File ui/file_manager/file_manager/foreground/js/file_manager.js (right): https://codereview.chromium.org/560273002/diff/1/ui/file_manager/file_manager/foreground/js/file_manager.js#newcode827 ui/file_manager/file_manager/foreground/js/file_manager.js:827: var listBeingUpdated = this.currentList_; Is it needed to assign ...
6 years, 3 months ago (2014-09-11 12:42:25 UTC) #3
mtomasz
https://codereview.chromium.org/560273002/diff/1/ui/file_manager/file_manager/foreground/js/file_manager.js File ui/file_manager/file_manager/foreground/js/file_manager.js (right): https://codereview.chromium.org/560273002/diff/1/ui/file_manager/file_manager/foreground/js/file_manager.js#newcode827 ui/file_manager/file_manager/foreground/js/file_manager.js:827: var listBeingUpdated = this.currentList_; On 2014/09/11 12:42:25, hirono wrote: ...
6 years, 3 months ago (2014-09-12 02:59:38 UTC) #4
hirono
lgtm!
6 years, 3 months ago (2014-09-12 03:17:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/560273002/40001
6 years, 3 months ago (2014-09-12 05:00:30 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001) as be51ba90179cd6e9f836cd86d25079699ed27afc
6 years, 3 months ago (2014-09-12 05:45:31 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 05:48:33 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8176b73b02e137a3c06afb7382a0a277338cc5ea
Cr-Commit-Position: refs/heads/master@{#294545}

Powered by Google App Engine
This is Rietveld 408576698