Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 560263003: Fix indentation for emacs (Closed)

Created:
6 years, 3 months ago by Fabrice (no longer in Chrome)
Modified:
6 years, 3 months ago
Reviewers:
pasko, tony, Nico, gavinp
CC:
gyp-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/gyp.git@master
Visibility:
Public.

Description

Fix indentation for emacs and add missing keyword. Closing brackets are now properly indented with the opening bracket. Also adds "cflags_cc" in the list of keywords BUG= r1975

Patch Set 1 #

Patch Set 2 : Indentation #

Patch Set 3 : Cleanup #

Total comments: 3

Patch Set 4 : Review comment #

Total comments: 4

Patch Set 5 : Review comment #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -11 lines) Patch
M tools/emacs/gyp.el View 1 2 3 4 3 chunks +12 lines, -11 lines 2 comments Download

Messages

Total messages: 13 (3 generated)
Fabrice (no longer in Chrome)
I have no idea who to add as reviewer. I am not too familiar with ...
6 years, 3 months ago (2014-09-11 12:34:40 UTC) #2
pasko
Adding Nico as he is the author of this file. what was the problem with ...
6 years, 3 months ago (2014-09-11 13:18:28 UTC) #4
Fabrice (no longer in Chrome)
On 2014/09/11 13:18:28, pasko wrote: > Adding Nico as he is the author of this ...
6 years, 3 months ago (2014-09-11 13:45:24 UTC) #5
pasko
+Gavin who actually knows CLisp and likely knows ELisp, at least he uses Emacs. https://codereview.chromium.org/560263003/diff/40001/tools/emacs/gyp.el ...
6 years, 3 months ago (2014-09-11 13:55:05 UTC) #7
gavinp
lgtm with clobber fixed https://codereview.chromium.org/560263003/diff/60001/tools/emacs/gyp.el File tools/emacs/gyp.el (right): https://codereview.chromium.org/560263003/diff/60001/tools/emacs/gyp.el#newcode21 tools/emacs/gyp.el:21: (if (and (eq major-mode 'gyp-mode) ...
6 years, 3 months ago (2014-09-11 14:15:55 UTC) #8
Fabrice (no longer in Chrome)
Thanks a lot for the comments Gavin! That should do it now. https://codereview.chromium.org/560263003/diff/60001/tools/emacs/gyp.el File tools/emacs/gyp.el ...
6 years, 3 months ago (2014-09-11 14:29:13 UTC) #9
Nico
I'm happy to land this, but I don't know elisp and don't use emacs. (I'm ...
6 years, 3 months ago (2014-09-11 15:20:34 UTC) #10
Fabrice (no longer in Chrome)
Modified the description, there was a missing keyword. I suppose this repo doesn't use the ...
6 years, 3 months ago (2014-09-11 15:24:48 UTC) #11
gavinp
Nico, I'll land this, since I have a bit more connection to the subject matter. ...
6 years, 3 months ago (2014-09-11 16:51:17 UTC) #12
gavinp
6 years, 3 months ago (2014-09-12 00:02:40 UTC) #13
On 2014/09/11 16:51:17, gavinp wrote:
> Nico, I'll land this, since I have a bit more connection to the subject
matter.
> sgty?

Nico,

I spoke too soon: I don't have the gyp commit juice. Could you bless this change
with your commitingnessosity powers?

Powered by Google App Engine
This is Rietveld 408576698