Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 560243002: Merge 181487 "Editing: Let Selection.collapse with null clears s..." (Closed)

Created:
6 years, 3 months ago by yoichio
Modified:
6 years, 3 months ago
Reviewers:
yoichio
CC:
blink-reviews, arv+blink, Inactive
Project:
blink
Visibility:
Public.

Description

Merge 181487 "Editing: Let Selection.collapse with null clears s..." > Editing: Let Selection.collapse with null clears selection. > > The current spec says Selection.collapse(null) raises exception and the > implementation follows. > However, many web apps assume that chrome clears selection when > Selection.collapse(null) calls. > Thus we revert the behavior. > > BUG=395318 > > Review URL: https://codereview.chromium.org/546703003 TBR=yoichio@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181788

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
A + LayoutTests/editing/selection/collapse-null.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/editing/selection/collapse-null-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/editing/DOMSelection.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M Source/core/editing/Selection.idl View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
yoichio
6 years, 3 months ago (2014-09-11 04:23:21 UTC) #1
yoichio
6 years, 3 months ago (2014-09-11 04:23:35 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r181788.

Powered by Google App Engine
This is Rietveld 408576698