First changelist of a series to migrate the component updater protocol

First changelist of a series to migrate the component updater protocol
from v2 to v3.

This CL only refactors the ping interceptor so that later on, update
checks can be intercepted and canned responses be served back.

Since v3 protocol uses http POST, a uniform way to intercept POST
requests is needed. The current interceptor works only for pings.
Support will be added later on to intercept update checks and
respond with specific XML.


BUG=314521
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233194

[waffles, 2013-11-04 18:32:45]

lgtm

https://codereview.chromium.org/56023005/diff/30001/chrome/browser/component_...
File chrome/browser/component_updater/test/component_updater_service_unittest.cc
(right):

https://codereview.chromium.org/56023005/diff/30001/chrome/browser/component_...
chrome/browser/component_updater/test/component_updater_service_unittest.cc:395:
"previousversion=\"0.9\" nextversion=\"1.0\"/></o:app>"));
I notice you're not printing the pings if we fail to find a match - I think it's
more likely that someone will break the tests by changing the ping text than by
changing the ping count; do we want to print the pings for the EXPECT_NE as
well?

Doesn't seem like a big deal (unless the tests get flaky again).

[Sorin Jianu, 2013-11-04 22:09:26]

Thank you Josh, PTAL.

[waffles, 2013-11-04 22:25:16]

lgtm, thanks

[cpu_(ooo_6.6-7.5), 2013-11-04 22:25:53]

rubberstamp lgtm

https://codereview.chromium.org/56023005/diff/110001/chrome/browser/component...
File chrome/browser/component_updater/test/url_request_post_interceptor.cc
(right):

https://codereview.chromium.org/56023005/diff/110001/chrome/browser/component...
chrome/browser/component_updater/test/url_request_post_interceptor.cc:103:
mutable std::vector<std::string> requests_;
is it worth to have all the interesting members as mutable?

[commit-bot: I haz the power, 2013-11-05 19:43:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sorin@chromium.org/56023005/110001

[commit-bot: I haz the power, 2013-11-05 22:39:49]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[Sorin Jianu, 2013-11-05 22:41:47]

Thank you Carlos!

https://codereview.chromium.org/56023005/diff/110001/chrome/browser/component...
File chrome/browser/component_updater/test/url_request_post_interceptor.cc
(right):

https://codereview.chromium.org/56023005/diff/110001/chrome/browser/component...
chrome/browser/component_updater/test/url_request_post_interceptor.cc:103:
mutable std::vector<std::string> requests_;
On 2013/11/04 22:25:53, cpu wrote:
> is it worth to have all the interesting members as mutable?

These members have to be mutable since the virtual function MaybeCreateJob that
is changing them is const by definition. We have to mutate these members, and so
the mutable type specifier.

[commit-bot: I haz the power, 2013-11-06 01:04:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sorin@chromium.org/56023005/110001

[commit-bot: I haz the power, 2013-11-06 02:37:45]

Change committed as 233194